Page MenuHomePhabricator
Create Task
Maniphest T253258

The visual mode left-justifies text on RTL wikis
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Go to https://ar.wikipedia.beta.wmflabs.org/wiki/%D9%86%D9%82%D8%A7%D8%B4_%D8%A7%D9%84%D9%85%D8%B3%D8%AA%D8%AE%D8%AF%D9%85%D8%A9:Whatamidoing_(WMF)?dtvisual=1
  2. Click the "Reply" button.
  3. Switch to visual mode.
  4. Type something.
  5. See your text on the left side of the box.

Details

SubjectRepoBranchLines +/-
Visual: Use createModelFromDom when setting documentmediawiki/extensions/DiscussionToolsmaster+4 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Whatamidoing-WMF created this task.May 20 2020, 7:17 PM
ppelberg removed projects: Editing Design, MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Editing QA.May 20 2020, 8:46 PM
ppelberg moved this task from Needs Discussion / Investigation to Upcoming on the Editing-team (Q3 2019-2020 Kanban Board) board.

(I removed the release tag considering I didn't see any patches linked to this task)

Esanders triaged this task as High priority.May 20 2020, 9:25 PM
gerritbot added a comment.May 20 2020, 9:27 PM

Change 597629 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Visual: Use createModelFromDom when setting document

https://gerrit.wikimedia.org/r/597629

gerritbot added a project: Patch-For-Review.May 20 2020, 9:27 PM
Esanders moved this task from Upcoming to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.May 20 2020, 9:28 PM
gerritbot added a comment.May 21 2020, 6:20 PM

Change 597629 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Visual: Use createModelFromDom when setting document

https://gerrit.wikimedia.org/r/597629

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 21 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 21 2020, 7:10 PM
matmarex added a project: Editing QA.May 21 2020, 7:48 PM
matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.May 28 2020, 10:45 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
Dyolf77_WMF added a comment.May 30 2020, 1:41 AM

Testing the tool on Arabic Wikipedia, something strange is happening when I tried to ping someone using @: the suggestion list is outside the box and in the wrong side.

Capture d'écran Deepin_zone de sélection _20200530015234.png (595×1 px, 136 KB)
I had to zoom out a little bit to read the list.

ppelberg moved this task from Needs Prioritization to Required for Release on the OWC2020 (OWC2020 Replying 2.0) board.Jun 1 2020, 12:20 AM
ppelberg mentioned this in T254115: The username suggestion list appears outside the Reply tool's text input area in RTL.Jun 1 2020, 1:35 AM
In T253258#6178550, @Dyolf77_WMF wrote:

Testing the tool on Arabic Wikipedia, something strange is happening when I tried to ping someone using @: the suggestion list is outside the box and in the wrong side.

Good catch, @Dyolf77_WMF. I've filed a new task for this issue: T254115

ppelberg closed this task as Resolved.Jun 1 2020, 1:36 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 1 2020, 1:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL