Page MenuHomePhabricator

Keep '@' prefix in username auto-complete output
Closed, ResolvedPublic

Description

  1. In the Reply tool's visual mode, type @ in a section where USER has commented
  2. Select USER from the username selection list

Actual behavior

  1. ⚠️Observe USER is shown in the Reply tool's visual text input area

Expected behavior

  1. ✅Observe @USER is shown in the Reply tool's visual text input area

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
Resolvedppelberg
Resolvedppelberg
Resolvediamjessklein
ResolvedWhatamidoing-WMF
Resolvedppelberg
ResolvedEsanders
Resolvedppelberg
Resolvedppelberg
ResolvedEsanders
ResolvedDLynch
Resolvediamjessklein
ResolvedEsanders
Resolvediamjessklein
ResolvedEsanders
Resolvedppelberg
ResolvedBUG REPORTppelberg
ResolvedBUG REPORTEsanders

Event Timeline

Did you want the @ to be inside or outside the link?

Did you want the @ to be inside or outside the link?

Good spot. Let's mimic how {{ping|USER}} behaves and show the @ outside the link. [1]


For RTL wikis, is it possible to use the symbol instead of the @? So {{ping|مستخدم}} will display مستخدم◀ ! (USER=مستخدم)

@Dyolf77_WMF this ticket is for the default -- T250332 is going to expose customizing the message so individual wikis can make it more to their liking.

@Dyolf77_WMF this ticket is for the default -- T250332 is going to expose customizing the message so individual wikis can make it more to their liking.

Thanks.

Esanders renamed this task from Change autcomplete output to Keep '@' prefix in username auto-complete output.May 20 2020, 11:27 AM
Esanders updated the task description. (Show Details)

Change 597515 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Prefix '@' to username auto-complete output

https://gerrit.wikimedia.org/r/597515

Change 597515 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Prefix '@' to username auto-complete output

https://gerrit.wikimedia.org/r/597515

Ryasmeen edited projects, added Verified; removed Editing QA.
ppelberg closed this task as Resolved.Jun 1 2020, 1:42 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 1 2020, 1:42 AM