Page MenuHomePhabricator

Remove "internal" and "external" tabs from the link inspector
Open, Needs TriagePublic

Description

In almost all cases we can tell the difference between an external link and an internal link. External links are only valid if they start with a protocol (e.g. "http://") and we automatically switch the user to external if they enter a protocol.

There is one edge case which is when the internal title begins with a protocol. Such pages exist on en.wiki, for example, but they are all redirects: https://en.wikipedia.org/wiki/Special:AllPages?from=http%3A%2F%2F&to=&namespace=0

I don't think it would be a great loss if we lost the ability to edit such links, and the simplification to the UI would we worth it.

image.png (190×425 px, 17 KB)

Event Timeline

iamjessklein moved this task from 📚 Backlog to 📐 Doing on the Editing Design board.

+1 thanks for writing this up @Esanders - I agree! In my latest round of mockups for Adding/Editing Links and Citations with Mobile Visual Editor I noticed that this is an unnecessarily clunky point in the flow.

Now that it's been a few weeks and we have a prototype up, it occurs to me that this implementation is probably not the direction that we are headed.

@Esanders implemented this as part of the prototype. Here's the screenshot of what it looks like. Note that since it's on the prototype server things will not appear 100% the way that we are intending them to appear.

Screen Shot 2019-06-11 at 9.41.35 AM.png (708×984 px, 53 KB)