Page MenuHomePhabricator

Test failure with WatchedItemQueryServiceExtension::modifyWatchedItemsWithRCInfoQuery()
Closed, ResolvedPublic

Description

The build for a PageCuration patch is failing with I believe to be something unrelated to our code: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/47716/console

22:55:26 Fatal error: Declaration of ORES\Hooks\Api\WatchedItemQueryServiceExtension::modifyWatchedItemsWithRCInfoQuery() must be compatible with that of WatchedItemQueryServiceExtension::modifyWatchedItemsWithRCInfoQuery() in /workspace/src/extensions/ORES/includes/Hooks/Api/WatchedItemQueryServiceExtension.php on line 28
22:55:26 Destructor threw an object exception: exception 'MWException' with message 'ORES\Tests\Api\ApiIntegrationTest::tearDown() must call parent::tearDown()' in /workspace/src/tests/phpunit/MediaWikiTestCase.php:159
22:55:26 Stack trace:
22:55:26 #0 (): MediaWikiTestCase->__destruct()
22:55:26 #1 {main}
22:55:26 Traceback (most recent call last):
22:55:26   File "/usr/local/bin/quibble", line 11, in <module>
22:55:26     load_entry_point('quibble==0.0.0', 'console_scripts', 'quibble')()
22:55:26   File "/usr/local/lib/python3.5/dist-packages/quibble/cmd.py", line 573, in main
22:55:26     cmd.execute()
22:55:26   File "/usr/local/lib/python3.5/dist-packages/quibble/cmd.py", line 545, in execute
22:55:26     junit_file=junit_db_file)
22:55:26   File "/usr/local/lib/python3.5/dist-packages/quibble/test.py", line 196, in run_phpunit_database
22:55:26     run_phpunit(*args, **kwargs)
22:55:26   File "/usr/local/lib/python3.5/dist-packages/quibble/test.py", line 191, in run_phpunit
22:55:26     subprocess.check_call(cmd, cwd=mwdir, env=phpunit_env)
22:55:26   File "/usr/lib/python3.5/subprocess.py", line 271, in check_call
22:55:26     raise CalledProcessError(retcode, cmd)

Event Timeline

Restricted Application added a project: Scoring-platform-team. · View Herald TranscriptMay 7 2019, 3:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle triaged this task as Unbreak Now! priority.May 7 2019, 3:08 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 7 2019, 3:08 PM

Change 508616 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/ORES@master] Fix method signatures in WatchedItemQueryServiceExtension

https://gerrit.wikimedia.org/r/508616

Change 508593 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Log breaking change to WatchedItemQueryServiceExtension

https://gerrit.wikimedia.org/r/508593

Change 508616 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Fix method signatures in WatchedItemQueryServiceExtension

https://gerrit.wikimedia.org/r/508616

Change 508593 merged by Bartosz Dziewoński:
[mediawiki/core@master] Log breaking change to WatchedItemQueryServiceExtension

https://gerrit.wikimedia.org/r/508593

matmarex closed this task as Resolved.May 7 2019, 6:25 PM
matmarex assigned this task to daniel.
matmarex added a subscriber: matmarex.

Seems good now. I was just able to merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/499494, which was previously failing due to this issue.

mmodell changed the subtype of this task from "Task" to "Production Error".Wed, Aug 28, 11:07 PM