Page MenuHomePhabricator

Show overlay when entering edit mode
Closed, ResolvedPublic

Description

_If_ user is not logged in

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2019, 10:00 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-15 board.

Change 510534 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Show IP warning overlay for anonymous users

https://gerrit.wikimedia.org/r/510534

Pablo-WMDE added a subscriber: Jakob_WMDE.
  • did some touches in https://gerrit.wikimedia.org/r/510534
  • tried in integration
  • observed (mind you, this is not on beta, yet - want to give us time to react to challenges before it arrives there to further speed up the iterations on beta)
    • would probably be the right thing to move the focus to the first button in the overlay when it opens (as you can see in the screenshot, the save button has focus [where previously "edit" was], which is the opposite of what we want, allowing you to save the [unaltered] entity through the overlay and being stuck with the overlay => T223542: Focus modal CTAs instead of publish button
    • not ideal that in my (firefox) browser the login & dismiss buttons for e.g. German copy wrap to separate lines which is handled gracefully (Hanna agrees on that) but against spec. As copy is variably long this will always have to be accounted for, but maybe we can change something to have it occur for fewer languages (e.g. font size, ...) @Lea_WMDE @Hanna_Petruschat_WMDE
    • warning should work on screens less wide, too => T223437: Make work at 320px width

Change 510534 merged by jenkins-bot:
[wikibase/termbox@master] Show IP warning overlay for anonymous users

https://gerrit.wikimedia.org/r/510534

Change 510835 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: use latest

https://gerrit.wikimedia.org/r/510835

Change 510835 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: use latest

https://gerrit.wikimedia.org/r/510835

Jakob_WMDE closed this task as Resolved.May 22 2019, 9:24 AM