Page MenuHomePhabricator

Gray interlanguage link dialog is misplaced
Open, NormalPublic

Description

First captured on English beta wiki, but happens in production as well. Notice how anchor is in line with gray interlanguage link, but dialog is displayed way up. I thought the reason is that gray interlanguage link is at the end of the viewport, but misalignment happens for long articles as well. This dialog should display anchored to the element going upwards, or downwards, expanding the page, like ULS does.

Event Timeline

Petar.petkovic renamed this task from Gray interlanguage link dialog is misplaced on testwiki to Gray interlanguage link dialog is misplaced.Jun 16 2019, 12:41 PM
Petar.petkovic updated the task description. (Show Details)
Pginer-WMF triaged this task as Normal priority.Jun 17 2019, 7:33 AM

Change 530576 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Correct the position of gray interlanguage link dialog

https://gerrit.wikimedia.org/r/530576

Change 530576 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Correct the position of gray interlanguage link dialog

https://gerrit.wikimedia.org/r/530576

When OOUI's PopupWidget cannot fit screen width, it goes backwards, which makes it unusable. I think that this is OOUI behavior, haven't checked. On my machine, using Chrome on Windows, threshold is ~690px. @Jpita came to me with this issue and reported ~640px for his machine. @Pginer-WMF is this behavior acceptable according to how small the width is, or should we fix this?

On 690px screen widthOn 680px screen width

@Pginer-WMF is this behavior acceptable according to how small the width is, or should we fix this?

If I understand it correctly, for screens/windows narrower than 690px the dialog is unreachable.
I think this needs to be fixed, but I'm ok capturing it on a separate ticket about adapting to small screens if you prefer.

@Pginer-WMF is this behavior acceptable according to how small the width is, or should we fix this?

If I understand it correctly, for screens/windows narrower than 690px the dialog is unreachable.
I think this needs to be fixed, but I'm ok capturing it on a separate ticket about adapting to small screens if you prefer.

Yes, dialog is unreachable on screens smaller than 690px. Separate ticket is not needed, problem can be tackled right here.

Change 536196 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Don't auto flip gray interlanguage link dialog

https://gerrit.wikimedia.org/r/536196

Change 536196 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Don't auto flip gray interlanguage link dialog

https://gerrit.wikimedia.org/r/536196