Gray interlanguage link dialog is misplaced
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Petar.petkovic
	Jun 3 2019, 1:10 PM

Description

First captured on English beta wiki, but happens in production as well. Notice how anchor is in line with gray interlanguage link, but dialog is displayed way up. I thought the reason is that gray interlanguage link is at the end of the viewport, but misalignment happens for long articles as well. This dialog should display anchored to the element going upwards, or downwards, expanding the page, like ULS does.

Details

	Subject	Repo	Branch	Lines +/-
	Don't auto flip gray interlanguage link dialog	mediawiki/extensions/ContentTranslation	master	+1 -0
	Correct the position of gray interlanguage link dialog	mediawiki/extensions/ContentTranslation	master	+23 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• santhosh	T217827 Update grey interlanguage links entry point popup
		Resolved		• Petar.petkovic	T224880 Gray interlanguage link dialog is misplaced

Event Timeline

• Petar.petkovic created this task.Jun 3 2019, 1:10 PM

• Petar.petkovic renamed this task from Gray interlanguage link dialog is misplaced on testwiki to Gray interlanguage link dialog is misplaced.Jun 16 2019, 12:41 PM

• Petar.petkovic updated the task description. (Show Details)

• Petar.petkovic mentioned this in T224792: Language dialog overlapping.Jun 16 2019, 12:53 PM

Pginer-WMF triaged this task as Medium priority.Jun 17 2019, 7:33 AM

Pginer-WMF added a project: Language-Team (Language-2019-April-June).

Pginer-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.Jun 17 2019, 10:43 AM

Etonkovidova added a parent task: T217827: Update grey interlanguage links entry point popup.Jun 27 2019, 12:10 PM

Etonkovidova mentioned this in T217827: Update grey interlanguage links entry point popup.Jun 27 2019, 12:17 PM

Pginer-WMF edited projects, added Language-Team (Language-2019-July-September); removed Language-Team (Language-2019-April-June).Jul 9 2019, 1:47 PM

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-July-September) board.Jul 31 2019, 9:02 AM

Change 530576 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Correct the position of gray interlanguage link dialog

https://gerrit.wikimedia.org/r/530576

gerritbot added a project: Patch-For-Review.Aug 16 2019, 1:48 PM

• Petar.petkovic claimed this task.Aug 16 2019, 1:48 PM

• Petar.petkovic moved this task from Priority backlog to In Review on the Language-Team (Language-2019-July-September) board.

Change 530576 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Correct the position of gray interlanguage link dialog

https://gerrit.wikimedia.org/r/530576

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 27 2019, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2019, 5:11 PM

Nikerabbit moved this task from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.Aug 27 2019, 6:25 PM

When OOUI's PopupWidget cannot fit screen width, it goes backwards, which makes it unusable. I think that this is OOUI behavior, haven't checked. On my machine, using Chrome on Windows, threshold is ~690px. @Jpita came to me with this issue and reported ~640px for his machine. @Pginer-WMF is this behavior acceptable according to how small the width is, or should we fix this?

On 690px screen width	On 680px screen width

https://gs.statcounter.com/screen-resolution-stats/desktop/worldwide
to help with the decision

• Jpita moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2019-July-September) board.Aug 31 2019, 1:11 PM

In T224880#5453977, @Petar.petkovic wrote:

@Pginer-WMF is this behavior acceptable according to how small the width is, or should we fix this?

If I understand it correctly, for screens/windows narrower than 690px the dialog is unreachable.
I think this needs to be fixed, but I'm ok capturing it on a separate ticket about adapting to small screens if you prefer.

In T224880#5478612, @Pginer-WMF wrote:

In T224880#5453977, @Petar.petkovic wrote:

@Pginer-WMF is this behavior acceptable according to how small the width is, or should we fix this?

If I understand it correctly, for screens/windows narrower than 690px the dialog is unreachable.
I think this needs to be fixed, but I'm ok capturing it on a separate ticket about adapting to small screens if you prefer.

Yes, dialog is unreachable on screens smaller than 690px. Separate ticket is not needed, problem can be tackled right here.

• Jpita moved this task from Pending input for QA to In Progress on the Language-Team (Language-2019-July-September) board.Sep 11 2019, 9:48 PM

Change 536196 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Don't auto flip gray interlanguage link dialog

https://gerrit.wikimedia.org/r/536196

gerritbot added a project: Patch-For-Review.Sep 12 2019, 2:20 PM

• Petar.petkovic moved this task from In Progress to In Review on the Language-Team (Language-2019-July-September) board.Sep 12 2019, 2:21 PM

Change 536196 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Don't auto flip gray interlanguage link dialog

https://gerrit.wikimedia.org/r/536196

• Petar.petkovic moved this task from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.Sep 17 2019, 7:59 AM

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.23; 2019-09-17); removed MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 17 2019, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2019, 8:10 AM

• Jpita closed this task as Resolved.Sep 26 2019, 4:01 PM

• Jpita moved this task from Needs QA to Done on the Language-Team (Language-2019-July-September) board.

Pginer-WMF edited projects, added CX-boost; removed ContentTranslation.Sep 27 2019, 9:37 AM