⚓ T225073 Add baserevid to wblremovesense API module

	Subject	Repo	Branch	Lines +/-
	Add baserevid to wblremovesense API module	mediawiki/extensions/WikibaseLexeme	master	+127 -8

		Status	Subtype	Assigned	Task
		Resolved		Lucas_Werkmeister_WMDE	T217243 Add baserevid to WikibaseLexeme API modules
		Resolved		Ladsgroup	T225073 Add baserevid to wblremovesense API module

Ladsgroup created this task.Jun 5 2019, 9:56 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJun 5 2019, 9:56 AM

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 11 2019, 12:20 PM

Change 517414 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Add baserevid to wblremovesense API module

https://gerrit.wikimedia.org/r/517414

gerritbot added a project: Patch-For-Review.Jun 17 2019, 12:40 PM

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 17 2019, 12:40 PM

• alaa_wmde moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 20 2019, 2:46 PM

Ladsgroup moved this task from Done to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 20 2019, 3:17 PM

Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:25 PM

Tests failing in a why that suggests something is not fully working, hence putting this back to Doing.

In T225073#5278048, @WMDE-leszek wrote:

Tests failing in a why that suggests something is not fully working, hence putting this back to Doing.

It was just a typo in the commit message

waaat, I was looking at what could be wrong in the code, and missed the Depens thing. thanks for fixing.

Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 28 2019, 9:41 AM

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 28 2019, 2:22 PM

Change 517414 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add baserevid to wblremovesense API module

https://gerrit.wikimedia.org/r/517414

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.14; 2019-07-16); removed MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).Jul 11 2019, 5:00 PM

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 11 2019, 6:05 PM

I have these Lexeme with a Sense and a Form. 2 editors (A and B)
B edits the Lexeme by removing the form.
few seconds after, A tries to edit the Lexeme by removing the Sense and gets an Error: sense Id not found. A only succeed after reloading the page

In T225073#5367865, @Rosalie_WMDE wrote:

I have these Lexeme with a Sense and a Form. 2 editors (A and B)
B edits the Lexeme by removing the form.
few seconds after, A tries to edit the Lexeme by removing the Sense and gets an Error: sense Id not found. A only succeed after reloading the page

I repeated and got a different output, it works just fine: https://wikidata.beta.wmflabs.org/w/index.php?title=Lexeme:L52&action=history

(Did you make sure to refresh the page after you added senses/forms?)