Page MenuHomePhabricator
Create Task
Maniphest T225183

$wgLexemeUseCirrus and $wgLexemeDisableCirrus both set to true for production
Closed, ResolvedPublic
Actions

Description

This is confusing if not wrong.

Details

ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+0 -4Remove $wgLexemeDisableCirrus
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Jun 6 2019, 8:37 AM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptJun 6 2019, 8:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Michael added a subscriber: Michael.Jun 6 2019, 9:30 AM
Reedy edited projects, added Wikimedia-Site-requests; removed CirrusSearch.Jun 6 2019, 9:47 AM
Reedy added a subscriber: Reedy.

$wgLexemeDisableCirrus seems to not exist in the repos anymore, so I'm guessing it's just a legacy holdover from the variable being renamed

Just needs Wikibase.php cleaning up in the mediawiki-config repo. I think just 4 lines to remove

gerritbot added a comment.Jun 6 2019, 11:44 AM

Change 514697 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Remove $wgLexemeDisableCirrus

https://gerrit.wikimedia.org/r/514697

gerritbot added a project: Patch-For-Review.Jun 6 2019, 11:44 AM
Smalyshev added a comment.Jun 6 2019, 4:09 PM

$wgLexemeDisableCirrus seems to not exist in the repos anymore

That's correct, this config was dropped in 2aadc02b5c9765a15beb657a0314f0bb5cffbda7 as part of the migration to WikibaseLexemeCirrusSearch extension. Should be removed.

debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.Jun 6 2019, 6:04 PM
debt added a subscriber: debt.
debt moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Jun 6 2019, 6:04 PM
gerritbot added a comment.Jun 6 2019, 11:53 PM

Change 514697 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove $wgLexemeDisableCirrus

https://gerrit.wikimedia.org/r/514697

Stashbot added a comment.Jun 6 2019, 11:56 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-06T23:56:01Z] <jforrester@deploy1001> Synchronized wmf-config/Wikibase.php: Remove T225183 (duration: 00m 48s)

Maintenance_bot removed a project: Patch-For-Review.Jun 7 2019, 12:10 AM
Smalyshev moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jun 8 2019, 3:39 AM
debt closed this task as Resolved.Jun 21 2019, 2:22 PM
debt claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL