Page MenuHomePhabricator
Create Task
Maniphest T225959

[Bug] Overflow menu has blank entry on community portal when no Wikidata item exists
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Steps to reproduce

  1. Login, enable AMC, and visit https://test2.m.wikipedia.org/wiki/Talk:Main_Page (or tap the community link in the main menu).
  2. Tap the overflow menu.

Expected results

  • The menu is sized to the items present.

Actual results

  • The minimum height is for four items but only three are present.
    it.m.wikipedia.org_wiki_Portale_Comunit%C3%A0.png (2×1 px, 544 KB)

Environments observed

  • Browser version: Chromium v74.0.3729.169
  • OS version: Ubuntu v19.04
  • Device model: Desktop
  • Device language: English

developer notes

The min-height is a little larger than it should be in this case. Set as 200px rather than 160px.
Can we detect when there is only three items and add a BEM modifier class? e..g .page-actions-overflow-list--compact ?

Details

SubjectRepoBranchLines +/-
[LESS] [content] lower content render ordermediawiki/skins/MinervaNeuemaster+5 -0
[UI] [menu] remove menu height resizingmediawiki/skins/MinervaNeuemaster+8 -53
Customize query in gerrit

Related Objects

Event Timeline

• Niedzielski created this task.Jun 17 2019, 5:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2019, 5:08 PM
• Niedzielski updated the task description. (Show Details)Jun 17 2019, 5:09 PM
ovasileva triaged this task as Medium priority.Jun 18 2019, 12:55 AM
ovasileva subscribed.

Note, this also happens on user pages

ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Jun 18 2019, 12:55 AM
ovasileva moved this task from Backlog to Triaged on the Advanced Mobile Contributions board.Jun 18 2019, 11:28 PM
Jdlrobson moved this task from Needs Prioritization to QA Tasks / Needs Reproduction on the Web-Team-Backlog board.Jul 9 2019, 12:03 AM
Jdlrobson subscribed.

This is not happening for me any more when I visit https://it.m.wikipedia.org/wiki/Portale:Comunit%C3%A0
Could this be only for pages without a Wikidata item?

ovasileva lowered the priority of this task from Medium to Low.Jul 9 2019, 3:14 AM
In T225959#5315759, @Jdlrobson wrote:

This is not happening for me any more when I visit https://it.m.wikipedia.org/wiki/Portale:Comunit%C3%A0
Could this be only for pages without a Wikidata item?

• Niedzielski renamed this task from [Bug] Overflow menu has blank entry on community portal to [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists.Jul 9 2019, 1:32 PM
• Niedzielski updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Jul 9 2019, 2:50 PM
Jdlrobson moved this task from QA Tasks / Needs Reproduction to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson raised the priority of this task from Low to Medium.Jul 31 2019, 2:35 PM

No wikidata item is actually pretty common on certain smaller wikis so we might want to reconsider this one..

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.Jul 31 2019, 3:15 PM
Jdlrobson moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Needs estimation

Jdlrobson updated the task description. (Show Details)Jul 31 2019, 4:14 PM
• Niedzielski added a comment.Jul 31 2019, 4:16 PM

Do we think the dynamic resizing on small screens is important? I'd love to drop that resizing JavaScript and this min-height CSS if document scrolling can be used instead.

• Niedzielski added a subscriber: • alexhollender_WMF.Jul 31 2019, 5:21 PM

@alexhollender says it's ok to remove menu resizing logic so we can remove the JS and the min-height.

Jdlrobson moved this task from Blocked on Others to Needs Analysis on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 31 2019, 5:23 PM
Jdlrobson set the point value for this task to 2.

We can resolve this by removing code by descoping the requirement of scrolling as you resize/rotate.

phuedx subscribed.Jul 31 2019, 5:28 PM

Note also that the above might fix T229399: [Bug] [AMC] 1px gap at bottom of page actions without download icon (due to font size usage) too.

gerritbot added a comment.Jul 31 2019, 5:39 PM

Change 526734 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] [UI] [menu] remove menu height resizing

https://gerrit.wikimedia.org/r/526734

gerritbot added a project: Patch-For-Review.Jul 31 2019, 5:40 PM
• Niedzielski moved this task from Needs Analysis to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 31 2019, 5:41 PM
gerritbot added a comment.Jul 31 2019, 8:42 PM

Change 526734 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] [UI] [menu] remove menu height resizing

https://gerrit.wikimedia.org/r/526734

Jdlrobson assigned this task to Edtadros.Jul 31 2019, 8:44 PM
Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Restricted Repository Identity mentioned this in rSKIN8df773e0145b: Update git submodules.Jul 31 2019, 8:44 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Jul 31 2019, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 31 2019, 9:10 PM
MBinder_WMF reassigned this task from Edtadros to ovasileva.Aug 7 2019, 5:21 PM
MBinder_WMF added a subscriber: Edtadros.
ovasileva added a comment.Aug 7 2019, 6:22 PM

@Niedzielski - unsure if this is just an issue with testwiki, but I'm seeing a weird overlap with the overflow menu on https://test.m.wikipedia.org/wiki/Talk:Main_Page

Screen Shot 2019-08-07 at 1.18.25 PM.png (1×986 px, 182 KB)

gerritbot added a comment.Aug 7 2019, 7:26 PM

Change 528911 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] [LESS] [content] lower content render order

https://gerrit.wikimedia.org/r/528911

gerritbot added a project: Patch-For-Review.Aug 7 2019, 7:26 PM
gerritbot added a comment.Aug 8 2019, 1:56 PM

Change 528911 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] [LESS] [content] lower content render order

https://gerrit.wikimedia.org/r/528911

Restricted Repository Identity mentioned this in rSKINee0b7c7da5b3: Update git submodules.Aug 8 2019, 1:59 PM
• Niedzielski added a comment.Aug 8 2019, 2:02 PM

@ovasileva, ^fix

Maintenance_bot removed a project: Patch-For-Review.Aug 8 2019, 2:10 PM
ovasileva moved this task from Needs QA to Blocked on Others on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Aug 8 2019, 5:05 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.20; 2019-08-27); removed MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 20 2019, 3:02 PM
Jdlrobson reassigned this task from ovasileva to Edtadros.Aug 20 2019, 5:18 PM
Jdlrobson moved this task from Blocked on Others to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
• Niedzielski reassigned this task from Edtadros to Jdlrobson.Aug 21 2019, 5:11 PM
Jdlrobson closed this task as Resolved.Aug 23 2019, 10:15 PM
Jdlrobson moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Confirmed fix.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits