Page MenuHomePhabricator
Create Task
Maniphest T226005

mwext-php70-phan-docker fails for WikibaseCirrusSearch
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

The CI phan job fails on WikibaseCirrusSearch since Wikibase introduced stubs for phan (T217018).

The reason is Wikibase now introduces stub classes for elasticsearch. Since WikibaseCirrusSearch depends on ElasticSearch the concrete classes are available and thus conflict with the stubs from Wikibase.

Example conflict:

\Wikibase\Search\Elastic\DispatchingQueryBuilder inherits Interface \CirrusSearch\Query\FullTextQueryBuilder
declared at ../../extensions/CirrusSearch/includes/Query/FullTextQueryBuilder.php:10

which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:225.

This may lead to confusing errors."
+ exec /srv/phan/vendor/bin/phan -d . -m checkstyle
A future major version of Phan will require PHP 7.1+ to run, but PHP 7.0.33-0+deb9u3 is installed.
PHP 7.0 reached its end of life in December 2018.
(Set PHAN_SUPPRESS_PHP_UPGRADE_NOTICE=1 to suppress this message)
RecursiveDirectoryIterator::__construct(includes/): failed to open dir: No such file or directory
RecursiveDirectoryIterator::__construct(maintenance/): failed to open dir: No such file or directory
RecursiveDirectoryIterator::__construct(.phan/stubs/): failed to open dir: No such file or directory
RecursiveDirectoryIterator::__construct(../../tests/phan/stubs): failed to open dir: No such file or directory
<?xml version="1.0" encoding="ISO-8859-15"?>
<checkstyle version="6.5">
  <file name="src/DispatchingQueryBuilder.php">
    <error line="13" severity="warning" message="\Wikibase\Search\Elastic\DispatchingQueryBuilder inherits Interface \CirrusSearch\Query\FullTextQueryBuilder declared at ../../extensions/CirrusSearch/includes/Query/FullTextQueryBuilder.php:10 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:225. This may lead to confusing errors." source="PhanRedefinedInheritedInterface"/>
  </file>
  <file name="src/ElasticTermResult.php">
    <error line="19" severity="warning" message="\Wikibase\Search\Elastic\ElasticTermResult inherits Interface \CirrusSearch\Search\ResultsType declared at ../../extensions/CirrusSearch/includes/Search/ResultsType.php:25 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:275. This may lead to confusing errors." source="PhanRedefinedInheritedInterface"/>
  </file>
  <file name="src/EntityFullTextQueryBuilder.php">
    <error line="23" severity="warning" message="\Wikibase\Search\Elastic\EntityFullTextQueryBuilder inherits Interface \CirrusSearch\Query\FullTextQueryBuilder declared at ../../extensions/CirrusSearch/includes/Query/FullTextQueryBuilder.php:10 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:225. This may lead to confusing errors." source="PhanRedefinedInheritedInterface"/>
  </file>
  <file name="src/EntityResult.php">
    <error line="13" severity="warning" message="\Wikibase\Search\Elastic\EntityResult extends Class \CirrusSearch\Search\Result declared at ../../extensions/CirrusSearch/includes/Search/Result.php:31 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:269. This may lead to confusing errors." source="PhanRedefinedExtendedClass"/>
  </file>
  <file name="src/EntityResultSet.php">
    <error line="10" severity="warning" message="\Wikibase\Search\Elastic\EntityResultSet extends Class \CirrusSearch\Search\ResultSet declared at ../../extensions/CirrusSearch/includes/Search/ResultSet.php:26 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:272. This may lead to confusing errors." source="PhanRedefinedExtendedClass"/>
  </file>
  <file name="src/EntityResultType.php">
    <error line="11" severity="warning" message="\Wikibase\Search\Elastic\EntityResultType extends abstract Class \CirrusSearch\Search\BaseResultsType declared at ../../extensions/CirrusSearch/includes/Search/BaseResultsType.php:8 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:282. This may lead to confusing errors." source="PhanRedefinedExtendedClass"/>
  </file>
  <file name="src/Query/HasDataForLangFeature.php">
    <error line="20" severity="warning" message="\Wikibase\Search\Elastic\Query\HasDataForLangFeature extends abstract Class \CirrusSearch\Query\SimpleKeywordFeature declared at ../../extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:18 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:228. This may lead to confusing errors." source="PhanRedefinedExtendedClass"/>
    <error line="20" severity="warning" message="\Wikibase\Search\Elastic\Query\HasDataForLangFeature inherits Interface \CirrusSearch\Query\FilterQueryFeature declared at ../../extensions/CirrusSearch/includes/Query/FilterQueryFeature.php:18 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:222. This may lead to confusing errors." source="PhanRedefinedInheritedInterface"/>
  </file>
  <file name="src/Query/HasWbStatementFeature.php">
    <error line="56" severity="warning" message="\Wikibase\Search\Elastic\Query\HasWbStatementFeature extends abstract Class \CirrusSearch\Query\SimpleKeywordFeature declared at ../../extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:18 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:228. This may lead to confusing errors." source="PhanRedefinedExtendedClass"/>
    <error line="56" severity="warning" message="\Wikibase\Search\Elastic\Query\HasWbStatementFeature inherits Interface \CirrusSearch\Query\FilterQueryFeature declared at ../../extensions/CirrusSearch/includes/Query/FilterQueryFeature.php:18 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:222. This may lead to confusing errors." source="PhanRedefinedInheritedInterface"/>
  </file>
  <file name="src/Query/InLabelFeature.php">
    <error line="26" severity="warning" message="\Wikibase\Search\Elastic\Query\InLabelFeature extends abstract Class \CirrusSearch\Query\SimpleKeywordFeature declared at ../../extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:18 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:228. This may lead to confusing errors." source="PhanRedefinedExtendedClass"/>
    <error line="26" severity="warning" message="\Wikibase\Search\Elastic\Query\InLabelFeature inherits Interface \CirrusSearch\Query\FilterQueryFeature declared at ../../extensions/CirrusSearch/includes/Query/FilterQueryFeature.php:18 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:222. This may lead to confusing errors." source="PhanRedefinedInheritedInterface"/>
  </file>
  <file name="src/Query/WbStatementQuantityFeature.php">
    <error line="46" severity="warning" message="\Wikibase\Search\Elastic\Query\WbStatementQuantityFeature extends abstract Class \CirrusSearch\Query\SimpleKeywordFeature declared at ../../extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:18 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:228. This may lead to confusing errors." source="PhanRedefinedExtendedClass"/>
    <error line="46" severity="warning" message="\Wikibase\Search\Elastic\Query\WbStatementQuantityFeature inherits Interface \CirrusSearch\Query\FilterQueryFeature declared at ../../extensions/CirrusSearch/includes/Query/FilterQueryFeature.php:18 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:222. This may lead to confusing errors." source="PhanRedefinedInheritedInterface"/>
  </file>
  <file name="src/WikibasePrefixSearcher.php">
    <error line="21" severity="warning" message="\Wikibase\Search\Elastic\WikibasePrefixSearcher extends Class \CirrusSearch\Searcher declared at ../../extensions/CirrusSearch/includes/Searcher.php:60 which is also declared at ../../extensions/Wikibase/.phan/stubs/cirrussearch.php:73. This may lead to confusing errors." source="PhanRedefinedExtendedClass"/>
  </file>
</checkstyle>

See https://integration.wikimedia.org/ci/job/mwext-php70-phan-docker/32909/console

Root case seems to be 494176.

Pinging @Smalyshev because he worked on 511127 and @Umherirrender because @hashar suggested it in #wikimedia-releng.

Related Objects

Event Timeline

zeljkofilipin created this task.Jun 18 2019, 10:56 AM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptJun 18 2019, 10:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
zeljkofilipin triaged this task as Medium priority.Jun 18 2019, 10:56 AM
zeljkofilipin mentioned this in T223774: The first Selenium test for WikibaseCirrusSearch.
hashar mentioned this in T217018: Upgrade Wikibase extension to use newer phan.Jun 18 2019, 11:18 AM
hashar added a project: Wikidata.Jun 18 2019, 11:21 AM
hashar updated the task description. (Show Details)
Smalyshev raised the priority of this task from Medium to High.Jun 18 2019, 5:20 PM
Smalyshev added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).
Smalyshev added subscribers: MaxSem, Jdforrester-WMF.Jun 18 2019, 5:26 PM
Legoktm subscribed.Jun 18 2019, 5:26 PM

WikibaseCirrusSearch shouldn't be importing .phan/stubs for analysis...

Smalyshev added a comment.Jun 18 2019, 5:29 PM

../../extensions/Wikibase/tests/phan/stubs/cirrussearch.php was in the ignore list, but since it has moved...

gerritbot added a comment.Jun 18 2019, 5:29 PM

Change 517700 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikibaseCirrusSearch@master] Update phan file path following rename in Wikibase

https://gerrit.wikimedia.org/r/517700

gerritbot added a project: Patch-For-Review.Jun 18 2019, 5:29 PM
Legoktm mentioned this in rEWCS005c18ed3250: Update phan file path following rename in Wikibase.Jun 18 2019, 5:30 PM
Umherirrender added a comment.Jun 18 2019, 5:30 PM
In T226005#5266335, @Legoktm wrote:

WikibaseCirrusSearch shouldn't be importing .phan/stubs for analysis...

The default is to include the whole extension repository, so it also includes .phan

gerritbot added a comment.Jun 18 2019, 5:32 PM

Change 517702 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ArticlePlaceholder@master] Update phan file path following rename in Wikibase

https://gerrit.wikimedia.org/r/517702

gerritbot added a comment.Jun 18 2019, 5:32 PM

Change 517703 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update phan file path following rename in Wikibase

https://gerrit.wikimedia.org/r/517703

Legoktm added a comment.Jun 18 2019, 5:33 PM

Submitted patches for all of https://codesearch.wmflabs.org/search/?q=Wikibase%2Ftests%2Fphan&i=nope&files=&repos=

Umherirrender mentioned this in rEWCS6d05be69835e: Update phan file path following rename in Wikibase.Jun 18 2019, 5:33 PM
Legoktm mentioned this in rEWLCd1097d63e0d8: Update phan file path following rename in Wikibase.Jun 18 2019, 5:33 PM
gerritbot added a comment.Jun 18 2019, 5:33 PM

Change 517704 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update phan file path following rename in Wikibase

https://gerrit.wikimedia.org/r/517704

Diffusion mentioned this in rEWLC0f48dc3c39ca: Update phan file path following rename in Wikibase.Jun 18 2019, 5:36 PM
gerritbot added a comment.Jun 18 2019, 5:45 PM

Change 517703 merged by Umherirrender:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update phan file path following rename in Wikibase

https://gerrit.wikimedia.org/r/517703

gerritbot added a comment.Jun 18 2019, 5:46 PM

Change 517704 abandoned by Umherirrender:
Update phan file path following rename in Wikibase

Reason:
Superseeded by Id52f6a521efeea253d9f9f955d682cf23697d08b

https://gerrit.wikimedia.org/r/517704

gerritbot added a comment.Jun 18 2019, 5:56 PM

Change 517700 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Update phan file path following rename in Wikibase

https://gerrit.wikimedia.org/r/517700

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 18 2019, 6:00 PM
Umherirrender closed this task as Resolved.Jun 18 2019, 6:06 PM
Umherirrender assigned this task to Legoktm.
gerritbot added a comment.Jun 18 2019, 6:19 PM

Change 517702 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Update phan file path following rename in Wikibase

https://gerrit.wikimedia.org/r/517702

hashar added a comment.Jun 18 2019, 7:15 PM

Thank you for the debugging/fix up! :-]

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits