Page MenuHomePhabricator
Create Task
Maniphest T226593

Fatal ApiReadingLists request: "deleteListEntry failed for unknown reason"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request URL: enwiki POST /w/api.php
Request ID: 9063c980-9799-11e9-80a0-29d2f94b7558 (HHVM)

message
LogicException: deleteListEntry failed for unknown reason
trace
#0 /srv/mediawiki/php-1.34.0-wmf.10/extensions/ReadingLists/src/Api/ApiReadingListsDeleteEntry.php(29): MediaWiki\Extensions\ReadingLists\ReadingListRepository->deleteListEntry(integer)
#1 /srv/mediawiki/php-1.34.0-wmf.10/extensions/ReadingLists/src/Api/ApiReadingLists.php(46): MediaWiki\Extensions\ReadingLists\Api\ApiReadingListsDeleteEntry->execute()
#2 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(1595): MediaWiki\Extensions\ReadingLists\Api\ApiReadingLists->execute()
#3 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(531): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.34.0-wmf.10/api.php(87): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): include(string)

Impact

(To be determined.)

Notes

Observed in Logstash since at least 1.34-wmf.6. Seen only from en.wikipedia.org.

See also:

Details

SubjectRepoBranchLines +/-
Fix missing column for ReadingListRepository::deleteListEntry loggingmediawiki/extensions/ReadingListsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jun 26 2019, 1:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2019, 1:42 AM
Krinkle added a comment.Jun 26 2019, 1:44 AM

The same requests also have the following error emitted, shortly before it reaches the fatal:

PHP Notice: Undefined property: stdClass::$rle_id

#0 /srv/mediawiki/php-1.34.0-wmf.10/extensions/ReadingLists/src/ReadingListRepository.php(740): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.10/extensions/ReadingLists/src/Api/ApiReadingListsDeleteEntry.php(29): MediaWiki\Extensions\ReadingLists\ReadingListRepository->deleteListEntry(integer)
#2 /srv/mediawiki/php-1.34.0-wmf.10/extensions/ReadingLists/src/Api/ApiReadingLists.php(46): MediaWiki\Extensions\ReadingLists\Api\ApiReadingListsDeleteEntry->execute()
#3 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(1595): MediaWiki\Extensions\ReadingLists\Api\ApiReadingLists->execute()
#4 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(531): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.34.0-wmf.10/api.php(87): ApiMain->execute()
Tgr subscribed.Jun 26 2019, 9:13 AM
In T226593#5284764, @Krinkle wrote:

The same requests also have the following error emitted, shortly before it reaches the fatal:

PHP Notice: Undefined property: stdClass::$rle_id

That's a bug, the rle_id field is indeed not included in the select.

gerritbot added a comment.Jun 26 2019, 9:14 AM

Change 519197 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@master] Fix missing column for ReadingListRepository::deleteListEntry logging

https://gerrit.wikimedia.org/r/519197

gerritbot added a project: Patch-For-Review.Jun 26 2019, 9:14 AM
Tgr mentioned this in rERLS787480eba5a0: Fix missing column for ReadingListRepository::deleteListEntry logging.Jun 26 2019, 9:14 AM
Tgr added a comment.Jun 26 2019, 9:17 AM

As for the main error, an UPDATE has no effect even though a row on which it is guaranteed to have effect has just been write-locked... no idea what could be going on there.

Tgr edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.Jun 26 2019, 2:13 PM
Krinkle moved this task from Untriaged to Jun 2019 / 1.34.wmf.8+ on the Wikimedia-production-error board.Jun 26 2019, 2:29 PM
Krinkle removed a project: Patch-For-Review.Jun 26 2019, 11:37 PM
gerritbot added a comment.Jul 1 2019, 7:14 PM

Change 519197 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Fix missing column for ReadingListRepository::deleteListEntry logging

https://gerrit.wikimedia.org/r/519197

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 1 2019, 8:00 PM
• Mholloway mentioned this in T227197: [BUG] Reading Lists Not Syncing — 11 lists synced.Jul 3 2019, 3:45 PM
Tgr added a comment.Jul 16 2019, 3:58 PM

Still happening, about once every two days (dashboard) so not related to opcache corruption (that was my first guess). User/list ID logging is fixed now so maybe that'll shed some light on it.

LGoto triaged this task as Medium priority.Jul 24 2019, 3:52 PM
LGoto edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Product-Infrastructure-Team-Backlog-Deprecated (Kanban).
LGoto moved this task from Needs triage to Needs investigation on the Product-Infrastructure-Team-Backlog-Deprecated board.
Krinkle mentioned this in Blog Post: Production Excellence #12: June 2019.Jul 31 2019, 6:44 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM
Krinkle closed this task as Resolved.Jan 29 2020, 7:30 PM

Not seen for at least 90 days.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits