Page MenuHomePhabricator

Fatal ApiReadingLists request: "deleteListEntry failed for unknown reason"
Open, NormalPublic

Description

Error

Request URL: enwiki POST /w/api.php
Request ID: 9063c980-9799-11e9-80a0-29d2f94b7558 (HHVM)

message
LogicException: deleteListEntry failed for unknown reason
trace
#0 /srv/mediawiki/php-1.34.0-wmf.10/extensions/ReadingLists/src/Api/ApiReadingListsDeleteEntry.php(29): MediaWiki\Extensions\ReadingLists\ReadingListRepository->deleteListEntry(integer)
#1 /srv/mediawiki/php-1.34.0-wmf.10/extensions/ReadingLists/src/Api/ApiReadingLists.php(46): MediaWiki\Extensions\ReadingLists\Api\ApiReadingListsDeleteEntry->execute()
#2 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(1595): MediaWiki\Extensions\ReadingLists\Api\ApiReadingLists->execute()
#3 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(531): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.34.0-wmf.10/api.php(87): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): include(string)

Impact

(To be determined.)

Notes

Observed in Logstash since at least 1.34-wmf.6. Seen only from en.wikipedia.org.

See also:

Event Timeline

Krinkle created this task.Jun 26 2019, 1:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2019, 1:42 AM

The same requests also have the following error emitted, shortly before it reaches the fatal:

PHP Notice: Undefined property: stdClass::$rle_id

#0 /srv/mediawiki/php-1.34.0-wmf.10/extensions/ReadingLists/src/ReadingListRepository.php(740): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.10/extensions/ReadingLists/src/Api/ApiReadingListsDeleteEntry.php(29): MediaWiki\Extensions\ReadingLists\ReadingListRepository->deleteListEntry(integer)
#2 /srv/mediawiki/php-1.34.0-wmf.10/extensions/ReadingLists/src/Api/ApiReadingLists.php(46): MediaWiki\Extensions\ReadingLists\Api\ApiReadingListsDeleteEntry->execute()
#3 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(1595): MediaWiki\Extensions\ReadingLists\Api\ApiReadingLists->execute()
#4 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(531): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.34.0-wmf.10/api.php(87): ApiMain->execute()
Tgr added a subscriber: Tgr.Jun 26 2019, 9:13 AM

The same requests also have the following error emitted, shortly before it reaches the fatal:

PHP Notice: Undefined property: stdClass::$rle_id

That's a bug, the rle_id field is indeed not included in the select.

Change 519197 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@master] Fix missing column for ReadingListRepository::deleteListEntry logging

https://gerrit.wikimedia.org/r/519197

Tgr added a comment.Jun 26 2019, 9:17 AM

As for the main error, an UPDATE has no effect even though a row on which it is guaranteed to have effect has just been write-locked... no idea what could be going on there.

Change 519197 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Fix missing column for ReadingListRepository::deleteListEntry logging

https://gerrit.wikimedia.org/r/519197

Tgr added a comment.Jul 16 2019, 3:58 PM

Still happening, about once every two days (dashboard) so not related to opcache corruption (that was my first guess). User/list ID logging is fixed now so maybe that'll shed some light on it.

mmodell changed the subtype of this task from "Task" to "Production Error".Wed, Aug 28, 11:06 PM