Page MenuHomePhabricator

Workflow for reviewing your changes (diff) to type in the edit summary is annoying
Closed, ResolvedPublic

Assigned To
Authored By
matmarex
Jul 2 2019, 12:30 AM
Referenced Files
F29732679: image.png
Jul 10 2019, 7:03 PM
F29732670: image.png
Jul 10 2019, 7:03 PM
F29732676: image.png
Jul 10 2019, 7:03 PM
F29732668: image.png
Jul 10 2019, 7:03 PM
F29674639: image.png
Jul 2 2019, 12:30 AM

Description

The workflow for reviewing your changes (diff) to type in the edit summary is annoying.

Scenario:

  1. Make changes to the page
  2. Click "Publish changes…" to save them
  3. Faced with the "Edit summary" field, click "Review my changes" to remind yourself what you did
  4. Click the back button in the top-left corner to go back to editing the edit summary

See, I pulled a fast one on ya! The back button is not actually in the top-left corner like it always is, it's instead in the bottom-left corner! The button in the top-left corner that you just clicked will close the entire dialog. (You scoff at yourself and look for the "Publish changes…" button again.)

image.png (641×924 px, 190 KB)

Replacing the verbose labels with close/back icons (T225021) would help a little. But I think we should actually just replace the current top-left button with the bottom-left button, so that clicking there goes back. To close the dialog entirely, you just click twice.

Alternatively, we could keep the edit summary field visible while reviewing changes (T148297), but that's a bit more involved.

Event Timeline

Change 520004 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] MWSaveDialog: Use close flag for close actions

https://gerrit.wikimedia.org/r/520004

For easy comparison:

DesktopMobile
Current
image.png (980×1 px, 485 KB)
image.png (667×375 px, 126 KB)
Proposed
image.png (980×1 px, 476 KB)
image.png (667×375 px, 124 KB)

In both cases, the button in top-left corner is changed from a "close" button to a "back" button, and the additional "back" button in bottom-left is removed.

Clearly much better on mobile :)

+1 (sorry for the delay) this is an obviously better proposal. 🛳 it.

Change 520004 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWSaveDialog: Use close flag for close actions, move 'back' button

https://gerrit.wikimedia.org/r/520004

ppelberg claimed this task.