Page MenuHomePhabricator
Create Task
Maniphest T229734

Convert button doesn't display since wmf.16
Closed, ResolvedPublic
Actions

Description

Steps to reproduce

  1. Go to https://cs.wikipedia.org/w/index.php?title=Za_%C4%BEud%C3%AD&oldid=17535284
  2. Open the article in VE
  3. Click any reference with only URL
  4. Expected: There should be "Convert" button, allowing users to convert it to fully featured reference, like in screenshot.
  5. Observed: There is no "Convert" button.

image.png (313×495 px, 33 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (aae84a489)mediawiki/extensions/VisualEditormaster+1 -1
Update VE core submodule to master (ab6d942c5)mediawiki/extensions/VisualEditormaster+1 -1
Only create context footer on mobileVisualEditor/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Aug 3 2019, 6:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2019, 6:51 PM
Janbery subscribed.Aug 3 2019, 6:54 PM
jeblad subscribed.Aug 4 2019, 1:10 PM

Also happen at nowiki.

Screenshot-menu-convert-2019-08-04.png (1×1 px, 200 KB)

Schnark added a project: Citoid.Aug 5 2019, 7:05 AM
Schnark subscribed.
Schnark added a subscriber: Esanders.Aug 5 2019, 7:31 AM

Since this works in mobile editor, I'm going to blame rECEX46014698791a: Move convert ref button to footer when the footer exists (even though that is wmf.16, not wmf.15).

Mvolz triaged this task as High priority.Aug 5 2019, 10:01 AM
gerritbot added a comment.Aug 5 2019, 11:12 AM

Change 528109 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Only create context footer on mobile

https://gerrit.wikimedia.org/r/528109

gerritbot added a project: Patch-For-Review.Aug 5 2019, 11:12 AM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Aug 5 2019, 11:13 AM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Aug 5 2019, 12:26 PM

Change 528109 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Only create context footer on mobile

https://gerrit.wikimedia.org/r/528109

Urbanecm renamed this task from Convert button doesn't display since wmf.15 to Convert button doesn't display since wmf.16.Aug 5 2019, 12:38 PM
In T229734#5391305, @Schnark wrote:

Since this works in mobile editor, I'm going to blame rECEX46014698791a: Move convert ref button to footer when the footer exists (even though that is wmf.16, not wmf.15).

(my typo, sorry, fixed)

Maintenance_bot removed a project: Patch-For-Review.Aug 5 2019, 1:10 PM
gerritbot added a comment.Aug 5 2019, 3:15 PM

Change 528173 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (32693b706)

https://gerrit.wikimedia.org/r/528173

gerritbot added a project: Patch-For-Review.Aug 5 2019, 3:15 PM
gerritbot added a comment.Aug 5 2019, 8:13 PM

Change 528253 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aae84a489)

https://gerrit.wikimedia.org/r/528253

gerritbot added a comment.Aug 5 2019, 8:25 PM

Change 528173 abandoned by Jforrester:
Update VE core submodule to master (ab6d942c5)

Reason:
Ed pushed Ic03c22a785a instead.

https://gerrit.wikimedia.org/r/528173

gerritbot added a comment.Aug 5 2019, 8:51 PM

Change 528253 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aae84a489)

https://gerrit.wikimedia.org/r/528253

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 5 2019, 9:09 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 5 2019, 9:10 PM
Patriccck subscribed.Aug 8 2019, 8:56 AM
Mvolz moved this task from Backlog to Waiting on Deploy on the Citoid board.Aug 8 2019, 1:56 PM
matmarex merged a task: T230123: "Convert" no longer available for plain links.Aug 8 2019, 3:50 PM
matmarex added a subscriber: Ahmad252.
matmarex mentioned this in T229654: "convert" button doesn't correctly detect if Citoid is enabled; we shouldn't offer convert button and message if automatic tab also isn't enabled..Aug 8 2019, 4:11 PM
matmarex added a project: Editing QA.Aug 9 2019, 4:48 PM
matmarex edited projects, added Skipped QA; removed Editing QA.Aug 9 2019, 4:52 PM
matmarex moved this task from QA to Product owner review on the VisualEditor (Current work) board.
matmarex subscribed.

I checked myself that it works as expected again on https://cs.wikipedia.org/w/index.php?title=Za_%C4%BEud%C3%AD&oldid=17535284 (the fix is already live in production).

jeblad added a comment.Aug 12 2019, 2:10 AM

Checked enwiki and nowiki, and works for me.

Ahmad252 added a comment.Aug 15 2019, 9:07 AM

Works fine in fawiki.

Ahmad252 lowered the priority of this task from High to Medium.Aug 15 2019, 9:10 AM
Urbanecm closed this task as Resolved.Aug 15 2019, 9:40 AM
Urbanecm assigned this task to Esanders.
Urbanecm raised the priority of this task from Medium to High.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits