In Prod example:
https://hi.wikipedia.org/wiki/राम_मूर्ति
Click on the first ref - it says click the convert button even though citoid is not enabled.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't show convert message if 'auto' mode is not available | mediawiki/extensions/Citoid | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Qgil | T128448 Technical Collaboration quarterly goals for April - June 2016 | |||
| Resolved | • Rfarrand | T131914 Technical Collaboration participation in Wikimania | |||
| Resolved | • Quiddity | T132624 Pre-Wikimania Hackathon 2016 Content Work | |||
| Open | None | T127354 Help some smaller Wikipedias' communities by writing the TemplateData and enabling citoid for them | |||
| Resolved | Mvolz | T229592 citoid dosen't work at Hindi Wikipedia | |||
| Resolved | BUG REPORT | • marcella | T229654 "convert" button doesn't correctly detect if Citoid is enabled; we shouldn't offer convert button and message if automatic tab also isn't enabled. |
Event Timeline
Comment Actions
This should be fixable in ve.ui.Citoid.init.js in the Citoid extension. 'auto' mode is available when ve.ui.mwCitoidMap is set, so we should check for this in ve.ui.MWReferenceContextItem.prototype.renderBody
Comment Actions
I asked to pull this into "Investigating" because I was very confused by the description. I think it was missing a "not", please check if that's right. Also, the issue is not reproducible at the given URL anymore, because Citoid was apparently enabled on the wiki. Is there another example?
Comment Actions
There isn't another live example because it only occurs under the following conditions:
The MediaWiki:Visualeditor-cite-tool-definition.json is defined
The MediaWiki:Citoid-template-type-map.json message is defined, but incorrectly, i.e. is missing required keys.
If both are undefined then old style citation is used without the inspector.
I fixed the broken config in the live example.
Ideally this shouldn't happen but it did here!
Comment Actions
Hi! I'm removing the good first task as this task doesn't seem to have clear next steps and lacks getting started instructions for a new contributor. If you disagree, put back the tag and add any necessary information in the task description.
Comment Actions
Change 576018 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Citoid@master] Don't show convert message if 'auto' mode is not available
Comment Actions
Change 576018 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] Don't show convert message if 'auto' mode is not available