Issue
Double tapping an existing link causes the Edit Card and keyboard to show simultaneously.
@MMiller_WMF caught this when testing. See screenshot below for illustration of issue:
Configuration
iOS + Safari
ppelberg | |
Aug 5 2019, 8:02 PM |
F29967315: image.png | |
Aug 5 2019, 8:02 PM |
Double tapping an existing link causes the Edit Card and keyboard to show simultaneously.
@MMiller_WMF caught this when testing. See screenshot below for illustration of issue:
iOS + Safari
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T221247 [Epic] Mobile context items | |||
Resolved | None | T229830 Edit Cards: deploy v3 to all wikis | |||
Resolved | Esanders | T229831 Implement Edit Cards v3 | |||
Resolved | Esanders | T229879 Keyboard and Edit Card show simultaneously when double-tapping link |
Change 528250 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] MobileContext: Ensure isVisible returns true while opening
Good spot. This happens on all platforms if the second click is within 250ms of the first because of animation that brings the edit card up. (250ms happens to also be the threshold for a double click on most platforms, but it's unrelated to double click events as it happens).
Change 528250 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] MobileContext: Ensure isVisible returns true while opening
Change 528253 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aae84a489)
Change 528253 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aae84a489)
Change 528277 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] MobileContext: Clear opening timeout when closing
Change 528277 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] MobileContext: Clear opening timeout when closing
Change 528486 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (70bf52198)
Change 528486 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (70bf52198)