Keyboard and Edit Card show simultaneously when double-tapping link
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Aug 5 2019, 8:02 PM

Description

Issue

Double tapping an existing link causes the Edit Card and keyboard to show simultaneously.

@MMiller_WMF caught this when testing. See screenshot below for illustration of issue:

Configuration

iOS + Safari

Details

Subject	Repo	Branch	Lines +/-
Update VE core submodule to master (70bf52198)	mediawiki/extensions/VisualEditor	master	+1 -1
MobileContext: Clear opening timeout when closing	VisualEditor/VisualEditor	master	+8 -5
Update VE core submodule to master (aae84a489)	mediawiki/extensions/VisualEditor	master	+1 -1
MobileContext: Ensure isVisible returns true while opening	VisualEditor/VisualEditor	master	+12 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T221247 [Epic] Mobile context items
Resolved	None	T229830 Edit Cards: deploy v3 to all wikis
Resolved	Esanders	T229831 Implement Edit Cards v3
Resolved	Esanders	T229879 Keyboard and Edit Card show simultaneously when double-tapping link

Event Timeline

• ppelberg created this task.Aug 5 2019, 8:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2019, 8:02 PM

• ppelberg added a parent task: T229831: Implement Edit Cards v3.Aug 5 2019, 8:03 PM

Esanders renamed this task from Keyboard and Edit Card show simultaneously when double-tapping link on iOS to Keyboard and Edit Card show simultaneously when double-tapping link.Aug 5 2019, 8:04 PM

Change 528250 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] MobileContext: Ensure isVisible returns true while opening

https://gerrit.wikimedia.org/r/528250

gerritbot added a project: Patch-For-Review.Aug 5 2019, 8:05 PM

Good spot. This happens on all platforms if the second click is within 250ms of the first because of animation that brings the edit card up. (250ms happens to also be the threshold for a double click on most platforms, but it's unrelated to double click events as it happens).

Esanders triaged this task as High priority.Aug 5 2019, 8:05 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

• ppelberg updated the task description. (Show Details)Aug 5 2019, 8:06 PM

Change 528250 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] MobileContext: Ensure isVisible returns true while opening

https://gerrit.wikimedia.org/r/528250

Maintenance_bot removed a project: Patch-For-Review.Aug 5 2019, 8:11 PM

Change 528253 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aae84a489)

https://gerrit.wikimedia.org/r/528253

gerritbot added a project: Patch-For-Review.Aug 5 2019, 8:13 PM

Change 528253 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aae84a489)

https://gerrit.wikimedia.org/r/528253

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 5 2019, 9:09 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 5 2019, 9:10 PM

Change 528277 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] MobileContext: Clear opening timeout when closing

https://gerrit.wikimedia.org/r/528277

gerritbot added a project: Patch-For-Review.Aug 5 2019, 9:53 PM

Esanders moved this task from QA to Code review on the VisualEditor (Current work) board.Aug 5 2019, 9:55 PM

Change 528277 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] MobileContext: Clear opening timeout when closing

https://gerrit.wikimedia.org/r/528277

Change 528486 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (70bf52198)

https://gerrit.wikimedia.org/r/528486

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 6 2019, 2:29 PM

Change 528486 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (70bf52198)

https://gerrit.wikimedia.org/r/528486

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2019, 3:10 PM

matmarex added a project: Editing QA.Aug 9 2019, 4:48 PM

matmarex moved this task from Inbox to High Priority on the Editing QA board.Aug 9 2019, 4:53 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.19; 2019-08-20).Aug 20 2019, 10:05 AM

Ryasmeen edited projects, added Verified; removed Editing QA.Aug 22 2019, 7:51 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

• ppelberg closed this task as Resolved.Sep 3 2019, 1:43 AM

MMiller_WMF unsubscribed.Sep 11 2019, 12:55 AM

Keyboard and Edit Card show simultaneously when double-tapping linkClosed, ResolvedPublicActions