Remove link label edit pencil from edit cards v3
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Aug 9 2019, 4:31 PM

Description

In order to test the consolidated approach to the link dialog, there should only be one edit pencil visible on the Edit Card, so not to confuse contributors with a second edit pencil that effectively does nothing [1].

Does nothing: technically, the link label edit pencil will lead contributors to a blank "Edit label" dialog

Details

	Subject	Repo	Branch	Lines +/-
	LinkAnnotationInspector: add a "label" field on mobile	VisualEditor/VisualEditor	master	+170 -67

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T221247 [Epic] Mobile context items
Resolved	None	T229830 Edit Cards: deploy v3 to all wikis
Resolved	Esanders	T229831 Implement Edit Cards v3
Resolved	ppelberg	T230213 Test edit cards v3 at Wikimania
Resolved	Esanders	T230214 Remove link label edit pencil from edit cards v3

Event Timeline

ppelberg created this task.Aug 9 2019, 4:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2019, 4:31 PM

ppelberg added a parent task: T230213: Test edit cards v3 at Wikimania.Aug 9 2019, 4:32 PM

As currently implemented:

Change 303956 had a related patch set uploaded (by Esanders; owner: DLynch):
[VisualEditor/VisualEditor@master] LinkAnnotationInspector: add a "label" field on mobile

https://gerrit.wikimedia.org/r/303956

gerritbot added a project: Patch-For-Review.Aug 10 2019, 3:46 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Aug 20 2019, 4:36 PM

Change 303956 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] LinkAnnotationInspector: add a "label" field on mobile

https://gerrit.wikimedia.org/r/303956

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2019, 11:10 PM

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 23 2019, 1:18 AM

matmarex added a project: Editing QA.Aug 23 2019, 1:39 AM

Ryasmeen edited projects, added Verified; removed Editing QA.Aug 27 2019, 9:11 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

ppelberg closed this task as Resolved.Aug 28 2019, 4:27 AM