Page MenuHomePhabricator

Do not autofocus any field in link dialog on Android
Closed, ResolvedPublic

Description

To properly test the consolidated approach to the link label dialog, neither field (link target or label) within the link dialog should be focused on Android when a contributor lands on that screen.

This is for the reasons Ed mentioned in chat:

  1. Having one edit button on the Edit Cards means we won't know which field to autofocus (label or link), considering we won't know which field the user is intending to interact with first
  2. On smaller devices, the autofocus may lead to other parts of the UI being hidden that we expect them to be able to see

  1. Consolidated approach: T229431

Event Timeline

Change 303956 had a related patch set uploaded (by Esanders; owner: DLynch):
[VisualEditor/VisualEditor@master] LinkAnnotationInspector: add a "label" field on mobile

https://gerrit.wikimedia.org/r/303956

Change 303956 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] LinkAnnotationInspector: add a "label" field on mobile

https://gerrit.wikimedia.org/r/303956