Page MenuHomePhabricator
Create Task
Maniphest T230336

Create entity save action
Closed, ResolvedPublic
Actions

Description

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
bridge: extend integration test regarding entity savemediawiki/extensions/Wikibasemaster+63 -0
bridge: add entity save actionmediawiki/extensions/Wikibasemaster+163 -24
bridge: inject WritingEntityRepository everywheremediawiki/extensions/Wikibasemaster+146 -19
bridge: add getter for full statements mapmediawiki/extensions/Wikibasemaster+39 -0
bridge: load mediawiki.ForeignApi ResourceLoader modulemediawiki/extensions/Wikibasemaster+12 -3
bridge: add wgUserName to mw.config type+mocksmediawiki/extensions/Wikibasemaster+17 -5
bridge: split constructor interface from ForeignApimediawiki/extensions/Wikibasemaster+2 -2
bridge: fix scriptPath in testsmediawiki/extensions/Wikibasemaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pablo-WMDE created this task.Aug 12 2019, 11:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2019, 11:51 AM
Michael edited projects, added Wikidata-Bridge-Sprint-3; removed Wikidata-Bridge.Aug 21 2019, 8:09 AM
• Pablo-WMDE added a project: Wikidata-Bridge-Sprint-4.Aug 28 2019, 8:34 AM
Lucas_Werkmeister_WMDE claimed this task.Aug 30 2019, 3:16 PM
Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-4 board.
gerritbot added a comment.Sep 2 2019, 4:42 PM

Change 533945 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: fix scriptPath in tests

https://gerrit.wikimedia.org/r/533945

gerritbot added a project: Patch-For-Review.Sep 2 2019, 4:42 PM

Change 533946 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: split constructor interface from ForeignApi

https://gerrit.wikimedia.org/r/533946

gerritbot added a comment.Sep 2 2019, 4:42 PM

Change 533947 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add wgUserName to mw.config type+mocks

https://gerrit.wikimedia.org/r/533947

gerritbot added a comment.Sep 2 2019, 4:42 PM

Change 533948 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: load mediawiki.ForeignApi ResourceLoader module

https://gerrit.wikimedia.org/r/533948

gerritbot added a comment.Sep 2 2019, 4:42 PM

Change 533949 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add getter for full statements map

https://gerrit.wikimedia.org/r/533949

gerritbot added a comment.Sep 2 2019, 4:42 PM

Change 533950 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: inject WritingEntityRepository everywhere

https://gerrit.wikimedia.org/r/533950

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 2 2019, 4:48 PM
gerritbot added a comment.Sep 2 2019, 4:56 PM

Change 533952 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add entity save action

https://gerrit.wikimedia.org/r/533952

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 2 2019, 4:56 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-4 board.
gerritbot added a comment.Sep 3 2019, 7:07 AM

Change 533945 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: fix scriptPath in tests

https://gerrit.wikimedia.org/r/533945

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 3 2019, 8:00 AM
Michael updated the task description. (Show Details)Sep 3 2019, 9:40 AM
gerritbot added a comment.Sep 3 2019, 12:11 PM

Change 533946 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: split constructor interface from ForeignApi

https://gerrit.wikimedia.org/r/533946

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 3 2019, 12:54 PM
gerritbot added a comment.Sep 4 2019, 5:09 AM

Change 533947 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add wgUserName to mw.config type+mocks

https://gerrit.wikimedia.org/r/533947

gerritbot added a comment.Sep 4 2019, 5:16 AM

Change 533948 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: load mediawiki.ForeignApi ResourceLoader module

https://gerrit.wikimedia.org/r/533948

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.22; 2019-09-10); removed MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 4 2019, 6:00 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 4 2019, 9:34 AM
gerritbot added a comment.Sep 4 2019, 5:37 PM

Change 533949 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add getter for full statements map

https://gerrit.wikimedia.org/r/533949

gerritbot added a comment.Sep 4 2019, 5:39 PM

Change 533950 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: inject WritingEntityRepository everywhere

https://gerrit.wikimedia.org/r/533950

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 5 2019, 10:29 AM
gerritbot added a comment.Sep 5 2019, 11:59 AM

Change 534601 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: extend integration test regarding entity save

https://gerrit.wikimedia.org/r/534601

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 5 2019, 1:00 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 5 2019, 1:49 PM

All the changes have been +2ed, so this should be done soon. Since it’s not wired up to anything yet, I suppose it doesn’t make sense to move it into the Verification column, so I’ll just wait for the merges to be done and then move to Done directly.

gerritbot added a comment.Sep 5 2019, 2:39 PM

Change 533952 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add entity save action

https://gerrit.wikimedia.org/r/533952

gerritbot added a comment.Sep 5 2019, 2:54 PM

Change 534601 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: extend integration test regarding entity save

https://gerrit.wikimedia.org/r/534601

Lucas_Werkmeister_WMDE closed this task as Resolved.Sep 5 2019, 2:58 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-4 board.
Maintenance_bot removed a project: Patch-For-Review.Sep 5 2019, 3:10 PM
Lucas_Werkmeister_WMDE mentioned this in T227003: Add an edit tag parameter and tag the edits made via data bridge with "Data Bridge".Sep 5 2019, 3:11 PM
Lucas_Werkmeister_WMDE added a comment.Sep 9 2019, 2:28 PM

Tested it on localhost, with repo wiki = client wiki, and it turns out ForeignApi doesn’t support that: T208601: ForeignApi adds the origin parameter even if the other wiki is on the same domain (esp. T208601#5475149). I think that shouldn’t be too hard to fix in ForeignApi, so perhaps we can pull that task into our sprint?

Lucas_Werkmeister_WMDE added a comment.Sep 9 2019, 2:36 PM

With a temporary change from ForeignApi to Api, though, the save works, so I think that’s the only bug :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits