Page MenuHomePhabricator

Add an edit tag parameter and tag the edits made via data bridge with "Data Bridge"
Closed, ResolvedPublic8 Story Points

Description

As a recent changes patroller on Wikidata I want to see which edits were made with the Wikidata Bridge in order to more easily identify problems with the tool or particular client templates.

All the edits made via Wikidata bridge will be tagged with the tag "Data Bridge".

Example:
edit with several tags

BDD
GIVEN a template is Wikidata Bridge enabled
WHEN an edit is made
THEN an edit tag is added to it on the repository

AC

  • All edits made via the Wikidata Bridge are tagged with an edit tag

Background

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2019, 2:49 PM
darthmon_wmde updated the task description. (Show Details)Jul 2 2019, 6:58 PM
darthmon_wmde renamed this task from Tag edits made via data bridge to Tag the edits made via data bridge.Jul 30 2019, 11:17 AM
darthmon_wmde renamed this task from Tag the edits made via data bridge to Tag the edits made via data bridge with "Data Bridge".
darthmon_wmde renamed this task from Tag the edits made via data bridge with "Data Bridge" to Add an edit tag parameter and tag the edits made via data bridge with "Data Bridge".Jul 30 2019, 11:25 AM
darthmon_wmde updated the task description. (Show Details)
darthmon_wmde set the point value for this task to 8.Jul 30 2019, 11:28 AM

openrefine seems to use versioned tags - that's something I could see us doing.
Also the question of adding the source client was quickly discussed in story writing.

TODO: verify how much there is left to do once T226999: Save Wikidata edit when submitting client edit modal is completed...

TODO: verify how much there is left to do once T226999: Save Wikidata edit when submitting client edit modal is completed...

As of T230336, ForeignApiWritingRepository supports a tags parameter, but it’s not initialized in createServices:

services.setWritingEntityRepository( new ForeignApiWritingRepository(
	new mwWindow.mw.ForeignApi(
		`${repoConfig.url}${repoConfig.scriptPath}/api.php`,
	),
	mwWindow.mw.config.get( 'wgUserName' ),
	// TODO tags from some config
) );

So as I see it, the following things are left to do:

  • create a (server-side) config setting in Wikibase Client for the tag(s)
  • embed that config variable in the browser-side code
  • use it (browser-side) to initialize the WritingEntityRepository
  • configure it in beta / production
Pablo-WMDE updated the task description. (Show Details)Sep 5 2019, 5:18 PM

Agreed, thanks! We can copy these to become (sub)tasks of the story once it is picked.
We might want to revise the existing estimation a bit, I think.

Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-5 board.Sep 13 2019, 2:08 PM

This should be working now on Beta, as far as I can tell, but I don’t think it can be tested until T230329: Use header component & save button is done.