Observed a few times in user testing, users get confused when pressing next appears to do nothing immediately. Then then repeatedly tap in the top right corner causing their edit to save immediately.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T221247 [Epic] Mobile context items | |||
| Resolved | None | T229830 Edit Cards: deploy v3 to all wikis | |||
| Resolved | Esanders | T229831 Implement Edit Cards v3 | |||
| Resolved | • ppelberg | T230213 Test edit cards v3 at Wikimania | |||
| Resolved | DLynch | T230816 Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown |
Event Timeline
Comment Actions
It appears just double tapping next will cause this. One option might be to disable the save/publish button at least until the opening transition has finished.
Comment Actions
After some research, it's a side-effect of a89c79dc7907fb32707c0fe535230cc04c38cae5 rather than being something tied to the save dialog actions -- intent is that if an accesskey hits the save-button while the save dialog is open, it triggers a save.
I can stick a brief "don't trigger a save during the dialog-opening" in there.
Comment Actions
Change 532737 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Don't let double-clicking the save button trigger a save
Comment Actions
Change 533059 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] WindowAction: Expose a promise when opening a window
Comment Actions
Change 533059 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] WindowAction: Expose a promise when opening a window
Comment Actions
Change 533346 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f3f6fae90)
Comment Actions
Change 533351 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f3f6fae90)
Comment Actions
Change 533351 abandoned by DLynch:
Update VE core submodule to master (f3f6fae90)
Reason:
Duplicate
Comment Actions
Change 533346 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4f3a331f6)
Comment Actions
Change 532737 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't let double-clicking the save button trigger a save
Comment Actions
@Ryasmeen: for testing, the most likely side effect of this patch would be somehow breaking the ability to use the save shortcut again while the save dialog is open to trigger a save.