Page MenuHomePhabricator
Create Task
Maniphest T230822

Include `dnsblacklist` in logs
Closed, ResolvedPublic
Actions

Description

To monitor if it's successful enough.

Details

SubjectRepoBranchLines +/-
Enable DNS blacklist on testwiki temporarilyoperations/mediawiki-configmaster+1 -0
Enable logging for BlockManager channel at info leveloperations/mediawiki-configmaster+1 -0
Log DNS blacklist matches with info level, non-matches with debug levelmediawiki/coremaster+16 -6
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Aug 20 2019, 5:31 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptAug 20 2019, 5:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Aug 20 2019, 5:31 PM

Change 531287 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Log DNS blacklist matches with info level, non-matches with debug level

https://gerrit.wikimedia.org/r/531287

gerritbot added a project: Patch-For-Review.Aug 20 2019, 5:31 PM
Urbanecm added a project: Platform Engineering.Aug 20 2019, 5:38 PM

Could Platform Engineering review my patch, please?

MarcoAurelio subscribed.Aug 20 2019, 5:46 PM
Urbanecm moved this task from Backlog to Working on on the User-Urbanecm board.Aug 20 2019, 6:18 PM
Eevans edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Aug 20 2019, 6:38 PM
gerritbot added a comment.Aug 20 2019, 7:06 PM

Change 531287 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Log DNS blacklist matches with info level, non-matches with debug level

https://gerrit.wikimedia.org/r/531287

gerritbot added a comment.Aug 20 2019, 7:16 PM

Change 531299 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Log dnsblacklist entries at info level

https://gerrit.wikimedia.org/r/531299

Urbanecm moved this task from Working on to Blocked on others on the User-Urbanecm board.Aug 20 2019, 8:50 PM
daniel moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Aug 21 2019, 11:00 AM
Urbanecm moved this task from Backlog to Blocked on development on the Wikimedia-Site-requests board.Aug 21 2019, 6:26 PM
daniel triaged this task as Medium priority.Aug 22 2019, 7:55 AM
Urbanecm moved this task from Blocked on others to Working on on the User-Urbanecm board.Aug 26 2019, 4:56 PM
Urbanecm moved this task from Working on to Backlog on the User-Urbanecm board.
Anomie moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Sep 3 2019, 3:16 PM
Anomie subscribed.

(Looks like this received CPT review. Move back if more review is needed.)

Urbanecm moved this task from External Code Review Completed to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Sep 14 2019, 4:34 PM

Patch updated.

Krinkle edited projects, added MediaWiki-Debug-Logger, MediaWiki-User-management; removed Wikimedia-Logstash, MediaWiki-Logevents.Sep 14 2019, 4:54 PM
Krinkle moved this task from Backlog to User blocking on the MediaWiki-User-management board.
gerritbot added a comment.Sep 14 2019, 8:16 PM

Change 531287 merged by jenkins-bot:
[mediawiki/core@master] Log DNS blacklist matches with info level, non-matches with debug level

https://gerrit.wikimedia.org/r/531287

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 14 2019, 9:00 PM
Urbanecm moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Sep 18 2019, 8:50 AM
Urbanecm moved this task from Backlog to Blocked on others on the User-Urbanecm board.
gerritbot added a comment.Sep 18 2019, 4:40 PM

Change 531299 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable logging for BlockManager channel at info level

https://gerrit.wikimedia.org/r/531299

Stashbot added a comment.Sep 18 2019, 4:43 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-18T16:43:45Z] <Urbanecm> 8340be9 sync is for T230822, mistakenly inserted test instead of the task number

Urbanecm closed this task as Resolved.Sep 18 2019, 4:44 PM

Should be done.

gerritbot added a comment.Sep 18 2019, 4:46 PM

Change 537691 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Enable DNS blacklist on testwiki temporarily

https://gerrit.wikimedia.org/r/537691

gerritbot added a comment.Sep 18 2019, 4:48 PM

Change 537691 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable DNS blacklist on testwiki temporarily

https://gerrit.wikimedia.org/r/537691

Stashbot added a comment.Sep 18 2019, 4:48 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-18T16:48:39Z] <urbanecm@deploy1001> Synchronized wmf-config/VariantSettings.php: SWAT: [[:gerrit:537691|Enable DNS blacklist on testwiki temporarily]] (T230822) (duration: 01m 03s)

Reedy subscribed.EditedSep 18 2019, 4:49 PM

To monitor if it's successful enough.

Successful at what exactly?

Urbanecm added a comment.Sep 18 2019, 4:53 PM
In T230822#5503778, @Reedy wrote:

To monitor if it's successful enough.

Successful at what exactly?

Sorry, I should've clarified. I want to make sure it doesn't block anything that should go through.

DannyS712 removed a project: Patch-For-Review.Nov 18 2019, 11:37 AM
DannyS712 subscribed.

[batch] remove patch for review tag from resolved tasks

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits