Page MenuHomePhabricator
Create Task
Maniphest T231935

GrowthExperiments not loading extension.json properly
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce: before 0ff60d1 (a hotfix), open help panel at any wiki that has custom links

Actual Results: Site help was displayed as the first link.

image.png (661×634 px, 49 KB)

Expected Results: No site help was displayed

Impact: Not known. Some users saw a bad link at prominent place. Noticed by @Urbanecm when demoing, hotfixed shortly after that.

Note: extension.json caused this problem. 5ef7faf changed default set of links from [] to Project:Help, in english. However, due to (something), that displayed at all wikis. @Urbanecm created 0ff60d1, a hotfix, to mitigate that. Deployed on September, 03, European evening, SAL entry

Details

SubjectRepoBranchLines +/-
Set correct merge strategy for help panel linksmediawiki/extensions/GrowthExperimentswmf/1.34.0-wmf.21+1 -0
Set correct merge strategy for help panel linksmediawiki/extensions/GrowthExperimentswmf/1.34.0-wmf.20+1 -0
Revert "[bugfix] Growth experiments not loading conf properly"operations/mediawiki-configmaster+1 -8
Set correct merge strategy for help panel linksmediawiki/extensions/GrowthExperimentsmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm created this task.Sep 3 2019, 7:21 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 3 2019, 7:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm triaged this task as Low priority.Sep 3 2019, 7:27 PM
Urbanecm updated the task description. (Show Details)

Mitigated => low

Urbanecm edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Sep 3 2019, 7:27 PM
Urbanecm moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm added subscribers: nettrom_WMF, kostajh, MMiller_WMF and 2 others.Sep 3 2019, 7:35 PM

Pinging a few involved people.

@Tgr (merged patch) @Catrope (consulted with him after hotfixing) @kostajh (created the patch that seems to broke this) to investigate further and implement a longer-term solution.

@MMiller_WMF @nettrom_WMF to discuss real impact and how important mitigations to prevent this in the future are.

kostajh added a comment.Sep 3 2019, 8:15 PM

@Urbanecm thank you for filing this and for the hotfix. You've set this to in progress, does that mean you're working on it? If so, please claim the task.

gerritbot added a comment.Sep 3 2019, 8:51 PM

Change 534233 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Set correct merge strategy for help panel links

https://gerrit.wikimedia.org/r/534233

gerritbot added a project: Patch-For-Review.Sep 3 2019, 8:51 PM
kostajh claimed this task.Sep 3 2019, 8:52 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Sep 3 2019, 9:34 PM

Change 534240 had a related patch set uploaded (by Catrope; owner: Catrope):
[operations/mediawiki-config@master] Revert "[bugfix] Growth experiments not loading conf properly"

https://gerrit.wikimedia.org/r/534240

gerritbot added a comment.Sep 3 2019, 9:48 PM

Change 534233 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Set correct merge strategy for help panel links

https://gerrit.wikimedia.org/r/534233

Urbanecm added a comment.Sep 3 2019, 9:50 PM
In T231935#5463007, @kostajh wrote:

@Urbanecm thank you for filing this and for the hotfix. You've set this to in progress, does that mean you're working on it? If so, please claim the task.

No, that the issue-solving is in progress. I solved the immediate issue by deploying a configuration change, which is a hack, but it solves the issue (extensionfunctions), see 0ff60d1. Not logged here, because I deployed before filling any task, and also before uploading to gerrit.

So, I was working on it, and I'm not now. The matter this task is about is in progress, but no one works on it ATM. Maybe "Ready for development" would be more appropriate?

gerritbot added a comment.Sep 3 2019, 9:54 PM

Change 534242 had a related patch set uploaded (by Catrope; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.21] Set correct merge strategy for help panel links

https://gerrit.wikimedia.org/r/534242

gerritbot added a comment.Sep 3 2019, 9:54 PM

Change 534243 had a related patch set uploaded (by Catrope; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.20] Set correct merge strategy for help panel links

https://gerrit.wikimedia.org/r/534243

Urbanecm mentioned this in T231947: Decide if/how to solve wrong link in GE projects to notice soon.Sep 3 2019, 9:57 PM
Urbanecm added a parent task: T231947: Decide if/how to solve wrong link in GE projects to notice soon.
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 3 2019, 10:00 PM
Urbanecm added a comment.Sep 3 2019, 10:02 PM

Filled T231947 to decide about testing this.

gerritbot added a comment.Sep 3 2019, 11:44 PM

Change 534240 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "[bugfix] Growth experiments not loading conf properly"

https://gerrit.wikimedia.org/r/534240

gerritbot added a comment.Sep 3 2019, 11:45 PM

Change 534243 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.20] Set correct merge strategy for help panel links

https://gerrit.wikimedia.org/r/534243

gerritbot added a comment.Sep 3 2019, 11:46 PM

Change 534242 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.21] Set correct merge strategy for help panel links

https://gerrit.wikimedia.org/r/534242

Stashbot added a comment.Sep 3 2019, 11:52 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-03T23:52:49Z] <niharika29@deploy1001> Synchronized php-1.34.0-wmf.20/extensions/GrowthExperiments/: Set correct merge strategy for help panel links T231935 (duration: 00m 56s)

Stashbot added a comment.Sep 3 2019, 11:53 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-03T23:53:58Z] <niharika29@deploy1001> Synchronized php-1.34.0-wmf.21/extensions/GrowthExperiments/: Set correct merge strategy for help panel links T231935 (duration: 00m 55s)

Stashbot added a comment.Sep 3 2019, 11:56 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-03T23:56:04Z] <niharika29@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Revert - [bugfix]Growth experiments not loading conf properly T231935 (duration: 00m 55s)

Stashbot added a comment.Sep 3 2019, 11:57 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-03T23:57:28Z] <niharika29@deploy1001> Synchronized wmf-config/CommonSettings.php: Revert - [bugfix]Growth experiments not loading conf properly T231935 (duration: 00m 55s)

• Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 3 2019, 11:58 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.20; 2019-08-27); removed MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 4 2019, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 4 2019, 12:10 AM
Etonkovidova closed this task as Resolved.Sep 4 2019, 9:44 PM
Urbanecm edited subscribers, added: Urbanecm_WMF; removed: Urbanecm.Aug 26 2020, 3:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits