Page MenuHomePhabricator

Add support for geo-coordinate Wikibase datatype for statements about commons files
Closed, ResolvedPublic

Description

User story: As a uploader, I want geo-coordinate support, so that I can specify the exact locations of where the image was taken or the objects portrayed in it.

We have this:
On the front-end, we currently only support statements which take as their input Wikidata entities or quantities

We want this:
We should have support geocoordinate input (at the very least at the same level as Wikidata does)

This ticket is for geo-coordinate support for main statements, and should only be attempted once T224060 (the same thing for qualifiers only) is done

Acceptance Criteria:

  • Users can add statements about files that have geo-coordinate values
  • Users can edit geo-coordinate values for statements
  • Users can see geo-coordinate values for statements
  • Precision (arcminute, arcsecond, ...) can be specified
  • All of the above should be available on the File page and in UploadWizard

QA Results

Event Timeline

Precision is currently not very user friendly on Wikidata if you want to set it. You might want to improve on that a bit and maybe can be backported later to Wikidata.

Change 554310 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Implement statement-level support for coordinates

https://gerrit.wikimedia.org/r/554310

Change 554310 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Implement statement-level support for coordinates

https://gerrit.wikimedia.org/r/554310

Assigning this one to Edward for a more thorough look.

Edtadros subscribed.

Test Result

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

File Page
https://commons.wikimedia.org/wiki/File:Malibu-superbloom.jpg

✅ AC1: Users can add statements about files that have geo-coordinate values

Screen Shot 2019-12-18 at 4.14.36 PM.png (537×812 px, 52 KB)

✅ AC2: Users can edit geo-coordinate values for statements
Screen Shot 2019-12-18 at 4.11.43 PM.png (406×813 px, 42 KB)

✅ AC3: Users can see geo-coordinate values for statements
Screen Shot 2019-12-18 at 4.42.20 PM.png (282×814 px, 31 KB)

✅ AC4: Precision (arcminute, arcsecond, ...) can be specified
Screen Shot 2019-12-18 at 4.12.28 PM.png (706×811 px, 100 KB)

UploadWizard
https://commons.m.wikimedia.org/wiki/File:Casino_Monte-Carlo.jpg

✅ AC5: Users can add statements about files that have geo-coordinate values

Screen Shot 2020-01-21 at 8.13.13 AM.png (202×601 px, 19 KB)

✅ AC6: Users can edit geo-coordinate values for statements

Screen Shot 2020-01-21 at 8.21.56 AM.png (404×822 px, 46 KB)

✅ AC7: Users can see geo-coordinate values for statements

Screen Shot 2020-01-21 at 8.23.04 AM.png (270×814 px, 34 KB)

✅ AC8: Precision (arcminute, arcsecond, ...) can be specified

Screen Shot 2020-01-21 at 8.21.56 AM.png (404×822 px, 46 KB)

Eric finished all the things :)