Page MenuHomePhabricator
Create Task
Maniphest T232814

Create controller object
Closed, ResolvedPublic
Actions

Description

AC:

  • new controller object that should always be loaded on Entity page load
  • should not be loaded on non-Entity pages
  • should receive the global config variable
  • global config variable should be exported to the controller

This should listen to the save hook and mutates the store (using the methods made available by the store implementer)
Make controller also listen to clicking edit link hook

In the event that the config variable is not true the the store should not be mutated.

Details

SubjectRepoBranchLines +/-
TR: Change default SET_ALL_TAINTED to SET_ALL_UNTAINTEDmediawiki/extensions/Wikibasemaster+18 -19
TR: Introduce TaintedCheckermediawiki/extensions/Wikibasemaster+109 -9
Add saved hook to HookHandlermediawiki/extensions/Wikibasemaster+53 -14
Introduce HookHandlermediawiki/extensions/Wikibasemaster+73 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

noarave created this task.Sep 13 2019, 8:43 AM
Tarrow subscribed.Sep 17 2019, 8:24 AM

We're postponing this task a little bit until we know more what our vue/JS interface will be like

WMDE-leszek added a project: Wikidata-Tainted-References-Sprint2.Sep 23 2019, 11:03 AM
Tarrow updated the task description. (Show Details)Sep 23 2019, 11:54 AM
Tarrow updated the task description. (Show Details)
WMDE-leszek added a project: Wikidata-Tainted-References-Sprint3.Oct 7 2019, 12:07 PM
Tarrow claimed this task.Oct 16 2019, 9:32 AM
Tarrow moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint3 board.
gerritbot added a comment.Oct 16 2019, 9:13 PM

Change 543702 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Introduce HookHandler

https://gerrit.wikimedia.org/r/543702

gerritbot added a project: Patch-For-Review.Oct 16 2019, 9:13 PM
gerritbot added a comment.Oct 21 2019, 2:17 PM

Change 544932 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Add saved hook to HookHandler

https://gerrit.wikimedia.org/r/544932

WMDE-leszek added a project: Wikidata-Tainted-References-Sprint4.Oct 22 2019, 9:36 AM
WMDE-leszek moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint4 board.
WMDE-leszek mentioned this in T232198: Display/hide a warning icon upon a trigger.Oct 22 2019, 9:39 AM
gerritbot added a comment.Oct 22 2019, 12:28 PM

Change 545265 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] DNM: TR: Introduce TaintedChecker

https://gerrit.wikimedia.org/r/545265

gerritbot added a comment.Oct 23 2019, 7:42 AM

Change 545450 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] TR: Change default SET_ALL_TAINTED to SET_ALL_UNTAINTED

https://gerrit.wikimedia.org/r/545450

Tarrow moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint4 board.Oct 23 2019, 8:50 AM
gerritbot added a comment.Oct 23 2019, 10:09 AM

Change 543702 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce HookHandler

https://gerrit.wikimedia.org/r/543702

gerritbot added a comment.Oct 23 2019, 10:14 AM

Change 544932 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add saved hook to HookHandler

https://gerrit.wikimedia.org/r/544932

gerritbot added a comment.Oct 23 2019, 10:18 AM

Change 545450 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] TR: Change default SET_ALL_TAINTED to SET_ALL_UNTAINTED

https://gerrit.wikimedia.org/r/545450

gerritbot added a comment.Oct 24 2019, 11:53 AM

Change 545265 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Introduce TaintedChecker

https://gerrit.wikimedia.org/r/545265

gerritbot added a comment.Oct 24 2019, 11:54 AM

Change 545450 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Change default SET_ALL_TAINTED to SET_ALL_UNTAINTED

https://gerrit.wikimedia.org/r/545450

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 24 2019, 12:00 PM
hoo subscribed.Oct 24 2019, 2:33 PM

@Tarrow I think we can consider this done, can't we?

hoo moved this task from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.Oct 24 2019, 2:48 PM
Tarrow closed this task as Resolved.Oct 29 2019, 10:40 AM
Tarrow moved this task from Test (Product Review) to Done on the Wikidata-Tainted-References-Sprint4 board.
DannyS712 removed a project: Patch-For-Review.Nov 18 2019, 11:34 AM
DannyS712 subscribed.

[batch] remove patch for review tag from resolved tasks

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL