Page MenuHomePhabricator

VE: Selecting/copying/deleting text that includes citation footnotes is broken in various ways
Closed, DuplicatePublic

Description

To illustrate, I will use Visual Editor to edit the following page:

https://en.wikipedia.org/w/index.php?title=Nils_Grandelius&oldid=918455762

using Chrome Version 77.0.3865.90 running on Windows 7.

  1. Select/highlight (by dragging the mouse while pressing the left mouse button) the lead paragraph, which contains two citation footnotes. Then hit Ctrl-X to delete the entire paragraph. Only the part of the text after the first footnote is deleted, and some other text is now highlighted. Undoing with Ctrl-Z does not work.
  1. Start over editing the page, now highlight the text in the first paragraph from "born" to "Swedish", which contains one footnote. Ctrl-X works as expected, except that afterwards some text is highlighted that shouldn't be. Ctrl-Z does not work.
  1. Start over editing the page. Highlight the last word "Sweden" in the first paragraph, including the following footnote. Trying to delete it with Ctrl-X has no effect. Now try to highlight some other word by double clicking on it: it doesn't work, "Sweden" is still highlighted.
  1. Start over and again highlight the last word "Sweden" in the first paragraph, including the following footnote. Hit Ctrl-C to copy it, and paste it somewhere else. This works as expected, but undoing with Ctrl-Z doesn't work.

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 28 2019, 7:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Titore added a subscriber: Titore.Sep 29 2019, 12:52 AM

Seems related to T233994.

ppelberg triaged this task as Unbreak Now! priority.Oct 2 2019, 9:42 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptOct 2 2019, 9:42 PM

Change 541088 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] TreeModifier: Ignore more attributes when validating linear data

https://gerrit.wikimedia.org/r/541088

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptOct 7 2019, 12:08 PM
dchan added a subscriber: dchan.Oct 8 2019, 6:57 AM

Example 3 is not fixed by Change Set 541088. It is a different bug, which I've filed separately as T234881 .