Page MenuHomePhabricator

"Restore", "undo", ... should warn about not being logged in
Closed, ResolvedPublic

Description

While clicking to editing an item I find it very helpful that a yellow box appears indicating that the user is not logged in. However, using "undo" or "restore" does not show this hint.

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterShow anon warning message on restore/undo pages

Event Timeline

Toni_001 created this task.Oct 2 2019, 1:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2019, 1:23 PM
Toni_001 updated the task description. (Show Details)Oct 2 2019, 1:24 PM
Toni_001 updated the task description. (Show Details)
Toni_001 renamed this task from "Create a new Item", "undo", ... do not warn about not being logged in to "Create a new Item", "undo", ... should warn about not being logged in.Oct 2 2019, 1:40 PM
DannyS712 renamed this task from "Create a new Item", "undo", ... should warn about not being logged in to "Restore", "undo", ... should warn about not being logged in.Oct 4 2019, 3:30 AM
DannyS712 updated the task description. (Show Details)
DannyS712 added a subscriber: DannyS712.

@Toni_001 Special:NewItem should show a warning:

"Warning: You are not logged in. Your IP address will be publicly visible if you make any edits. If you log in or create an account, your edits will be attributed to a user name, among other benefits."

But, I checked, and neither undo nor restore show the warning

Change 560840 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/Wikibase@master] Show anon warning message on restore/undo pages

https://gerrit.wikimedia.org/r/560840

Change 560840 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Show anon warning message on restore/undo pages

https://gerrit.wikimedia.org/r/560840

Ello! I was checking this ticket and it would be great if the OOUI styleguide for warning messages would be used here (MessageWidget (type: 'warning')) with a font size of 14 as can be seen in the demo
screenshot from the ooui demo page


It would be awesome if you could adapt the design to this. thank you!

It would be awesome if you could adapt the design to this. thank you!

I'll file a separate ticket for that (as it needs to be changed in multiple places I believe)