Page MenuHomePhabricator

ApiPageTriageList: don't assume talk_page_title is in the 'Talk:' namespace
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The value returned is "Talk:Draft:Williopsis"

What should have happened instead?:
The value returned should be "Draft talk:Williopsis" (or whatever prefix is set for the Draft Talkspace in LocalSettings.php (underscores here would be replaced with spaces))

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 changed the subtype of this task from "Task" to "Bug Report".

Change 540693 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] PageTriageList: provide correct talk_page_title

https://gerrit.wikimedia.org/r/540693

@MusikAnimal would the growth team / you be willing to review the patch provided?

Still able to reproduce as of 11/09/22. Will try to get the above patch to pass CI so we can merge it.

I'd be happy to review this, but I'm going to need some better QA steps for this ticket (e.g. written for somebody who has basic knowledge of how PageTriage works) to understand what the issue here so I can confirm the fix.

I'd be happy to review this, but I'm going to need some better QA steps for this ticket (e.g. written for somebody who has basic knowledge of how PageTriage works) to understand what the issue here so I can confirm the fix.

@Jdlrobson, I've added QA steps to the ticket description.

Thanks for the replication steps. That was very helpful. Results from testing...

Before:

Screenshot 2023-03-31 at 11.33.54 AM.png (426×2 px, 145 KB)

after:
Screenshot 2023-03-31 at 11.36.41 AM.png (692×2 px, 258 KB)

Note, if the draft talk namespace is not defined, this will result in a bad title. I don't think this is likely to happen in Wikimedia production, but for completeness it may make sense to omit the field entirely when that's the case (suggest this is tackled in a follow up)
Example configuration:

$wgPageTriageDraftNamespaceId = 118;
$wgExtraNamespaces[ $wgPageTriageDraftNamespaceId ] = 'Draft';
// disable talk namespace
// $wgExtraNamespaces[ $wgPageTriageDraftNamespaceId + 1 ] = 'Draft_talk';

Screenshot 2023-03-31 at 11.33.26 AM.png (506×2 px, 176 KB)

Change 540693 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] PageTriageList: Provide correct `talk_page_title`

https://gerrit.wikimedia.org/r/540693