Maniphest T234977

Fix issues with deeplinks and external links interactions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• JMinor
	Oct 8 2019, 5:39 PM

Tags

Referenced Files

None

Subscribers

Description

See child tickets.

The general rules should be:

If there is a specialized native display (such as articles or user talk) use it
Else if the link is hosted by Wikimedia open in the in app browser
Else if the link is any other URL open in the Safari app

URL type	opens in
Article	reader view
Talk	in app browser
User Talk	talk view
User	in app browser
Main pages	in app browser
Non article content portals: wiki projects, etc	in app browser
Other special pages and misc namespaces on wiki	in app browser
other links on any wikimedia domain (donate.wikimedia.org, mediawiki, etc)	in app browser
External links not on a wikimedia domain	Safari

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		JoeWalsh	T234977 Fix issues with deeplinks and external links interactions
		Resolved		• JMinor	T231197 link in notification mail opens the wikipedia app with the wrong link
		Declined	BUG REPORT	None	T233574 [OTRS] Some links opening with mobile web interface in the app?
		Invalid	BUG REPORT	None	T227676 Deep links don't work for non /wiki/ URLs
		Resolved	BUG REPORT	JoeWalsh	T234064 Some wiki links from Safari open in the app and then redirect back to Safari
		Duplicate	BUG REPORT	None	T235322 Talk page message notification email link leads to the Wikipedia article namespace in the iOs app

Event Timeline

• JMinor created this task.Oct 8 2019, 5:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 8 2019, 5:39 PM

• JMinor triaged this task as Medium priority.Oct 8 2019, 5:40 PM

LGoto added subtasks: T231197: link in notification mail opens the wikipedia app with the wrong link, T233574: [OTRS] Some links opening with mobile web interface in the app?, T227676: Deep links don't work for non /wiki/ URLs, T234064: Some wiki links from Safari open in the app and then redirect back to Safari.Oct 8 2019, 5:42 PM

LGoto moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.

LGoto moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Oct 8 2019, 5:45 PM

Reminder: test all fixes with non-EN pages/links.

Make sure documentation for testing and users on deep links is as clear as possible.

User talk archives or archives

LGoto added a subtask: T235322: Talk page message notification email link leads to the Wikipedia article namespace in the iOs app.Oct 21 2019, 6:47 PM

• JMinor updated the task description. (Show Details)Oct 29 2019, 5:25 PM

• JMinor updated the task description. (Show Details)Oct 29 2019, 5:32 PM

• JMinor updated the task description. (Show Details)

• JMinor moved this task from Needs Acceptance Criteria to Needs Engineering Sync on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.

• JMinor removed • JMinor as the assignee of this task.Oct 29 2019, 6:19 PM

• JMinor moved this task from Needs Engineering Sync to Ready for Development on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Oct 29 2019, 6:24 PM

• JMinor closed subtask T233574: [OTRS] Some links opening with mobile web interface in the app? as Declined.Oct 29 2019, 6:35 PM

• JMinor closed subtask T227676: Deep links don't work for non /wiki/ URLs as Invalid.

Mhurd claimed this task.Nov 12 2019, 9:52 PM

Mhurd moved this task from Ready for Development to Doing on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.

Previous related ticket:
https://phabricator.wikimedia.org/T232648

Revision/Diff related:
https://phabricator.wikimedia.org/T228789

Tsevener mentioned this in T234064: Some wiki links from Safari open in the app and then redirect back to Safari.Nov 20 2019, 8:30 PM

Added supporting methods for determining namespace/mainpage by examining link urls: https://github.com/wikimedia/wikipedia-ios/pull/3345

Mhurd reassigned this task from Mhurd to JoeWalsh.Nov 21 2019, 6:44 PM

Tsevener moved this task from Doing to Needs QA on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 26 2019, 3:45 PM

• JMinor closed subtask T234064: Some wiki links from Safari open in the app and then redirect back to Safari as Resolved.Dec 2 2019, 6:48 PM

I think I have most of these covered on 6.5.0 (1700)

• JMinor closed this task as Resolved.Dec 6 2019, 12:44 AM

• JMinor closed subtask T231197: link in notification mail opens the wikipedia app with the wrong link as Resolved.May 15 2020, 12:58 AM