Creating a PDF with collection extension does not render the <pages> tag hook from proofread page extension
Closed, ResolvedPublic

Description

Go here: http://fr.wikisource.org/wiki/Le_salut_est_en_vous/Chapitre_4
Click on "Télécharger comme PDF".


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66597

bzimport set Reference to bz21653.
Yann created this task.Nov 26 2009, 11:40 PM
Yann added a comment.Nov 26 2009, 11:42 PM

PDF created with the collection extension

Attached: Le_Salut_est_en_vous_4.pdf

Yann added a comment.Nov 26 2009, 11:46 PM

I changed the severity to "major" as this extension, which is much needed on Wikisource, is completely useless now.

It also doesn't understand books whose list of pages are created by a templete, as described at
[[Help:Books/Feedback/Archives/2010/May#The_extension_is_not_parsing_templates]]

He7d3r added a comment.Jan 1 2011, 7:30 PM

(In reply to comment #4)

It also doesn't understand books whose list of pages are created by a templete,
as described at
[[Help:Books/Feedback/Archives/2010/May#The_extension_is_not_parsing_templates]]

I've described this on Bug 26533.

thomasV1 wrote:

any progress ?

Could someone provide us some update about the progress in solving this bug?

This one has close similarities with bug 18861 in when page expansion/transclusion takes place with relation to other events on the page. Both are quite problematic in their operations, have major effects at Wikisource, and there seems neither action nor care on either.

Can someone point me to the relevant contact information for the person/team that manages this extension. The extension's failure is a major issue at English Wikisource.

I've attempted adding the relevant pediapress devs to the CC for this bug.

Tfinc added a comment.Jul 26 2011, 9:49 PM

Thanks for adjusting the priority. I'll make sure to get Heiko @ PediaPress to triage this.

As either another pointer, or maybe a red herring. Someone has pointed out this email to me. It suggest to load [[Extension:Labeled Section Transclusion]] prior to loading [[Extension:Collection]] in the LocalSettings.php

Could that be tried? Thanks.

http://groups.google.com/group/mwlib/browse_thread/thread/873446fa78791362
"Labeled Section Transclusion" extension not compatible?

post 1

David
More options Jul 19, 6:37 pm

Sections that are transcluded into a page using the Labeled Section
Transclusion extensionhttp://www.mediawiki.org/wiki/Extension:Labeled_Section_Transclusion do
not show up in downloaded PDFs or ODTs. Is it possible to make that happen?

Best,
David

post 2

I believe I have fixed this problem by loading the Labeled Section
Transclusion extension before Collection in LocalSettings.php.

Thanks,

David

Bumping priority so we can get some momentum going (hopefully) with PediaPress or a volunteer.

ralf_wikimedia wrote:

I'll work on that if time permits.

ralf_wikimedia wrote:

implemented in mwlib 0.13.2, which is already live on pdf cluster.

please report further issues on github: https://github.com/pediapress/mwlib/issues/new

Given everytime i try to create a pdf of something I end up with a giant error, this is hard to test if it works now:

(For reference, error was from [[s:The_Panama_Canal_Controversy]] but i tried several pages. And I didn't report on github because i don't have an account there. Of course this is probably a totally separate issue from the <page> issue):

An error occured on the render server: RuntimeError: command failed with returncode 256: ['mw-render', '-w', 'rl', '-c', 'cache/e8/e866fe89f5be0acb/collection.zip', '-o', 'cache/e8/e866fe89f5be0acb/output.rl', '--status', 'qserve://localhost:14311/e866fe89f5be0acb:render-rl', '--template-blacklist', 'MediaWiki:PDF Template Blacklist', '--template-exclusion-category', 'Exclude in print', '--print-template-prefix', 'Print', '--print-template-pattern', '$1/Print', '--language', 'en'] Last Output: writer(env, output=tmpout, status_callback=self.status, writer_options) File "/home/pp/local/lib/python2.6/site-packages/mwlib.rl-0.12.10-py2.6.egg/mwlib/rl/rlwriter.py", line 2181, in writer r.writeBook(output=output, coverimage=coverimage, status_callback=status_callback) File "/home/pp/local/lib/python2.6/site-packages/mwlib.rl-0.12.10-py2.6.egg/mwlib/rl/rlwriter.py", line 469, in writeBook art = self.buildArticle(item) File "/home/pp/local/lib/python2.6/site-packages/mwlib.rl-0.12.10-py2.6.egg/mwlib/rl/rlwriter.py", line 358, in buildArticle revision=item.revision) File "/home/pp/local/lib/python2.6/site-packages/mwlib-0.13.2-py2.6-linux-x86_64.egg/mwlib/nuwiki.py", line 421, in getParsedArticle return uparser.parseString(title=title, raw=raw, wikidb=self, lang=self.siteinfo["general"]["lang"]) File "/home/pp/local/lib/python2.6/site-packages/mwlib-0.13.2-py2.6-linux-x86_64.egg/mwlib/refine/uparser.py", line 63, in parseString a = compat.parse_txt(input, title=title, wikidb=wikidb, nshandler=nshandler, lang=lang, magicwords=magicwords, uniquifier=uniquifier, expander=te) File "/home/pp/local/lib/python2.6/site-packages/mwlib-0.13.2-py2.6-linux-x86_64.egg/mwlib/refine/compat.py", line 193, in parse_txt sub = core.parse_txt(raw, kwargs) File "/home/pp/local/lib/python2.6/site-packages/mwlib-0.13.2-py2.6-linux-x86_64.egg/mwlib/refine/core.py", line 1037, in parse_txt combined_parser(parsers)(tokens, xopts) File "/home/pp/local/lib/python2.6/site-packages/mwlib-0.13.2-py2.6-linux-x86_64.egg/mwlib/refine/core.py", line 646, in call p(x, xopts) File "/home/pp/local/lib/python2.6/site-packages/mwlib-0.13.2-py2.6-linux-x86_64.egg/mwlib/refine/core.py", line 762, in init tokens[i] = m(name, vlist, inner or u"", xopts) File "/home/pp/local/lib/python2.6/site-packages/mwlib-0.13.2-py2.6-linux-x86_64.egg/mwlib/refine/core.py", line 887, in create_pages children = parse_txt(te.expandTemplates(True), File "evaluate.py", line 295, in mwlib.templ.evaluate.Expander.expandTemplates (mwlib/templ/evaluate.c:5932) File "evaluate.py", line 282, in mwlib.templ.evaluate.Expander._expand (mwlib/templ/evaluate.c:5569) File "evaluate.py", line 28, in mwlib.templ.evaluate.flatten (mwlib/templ/evaluate.c:1103) File "evaluate.py", line 30, in mwlib.templ.evaluate.flatten (mwlib/templ/evaluate.c:1134) File "nodes.py", line 210, in mwlib.templ.nodes.Template.flatten (mwlib/templ/nodes.c:4619) File "nodes.py", line 291, in mwlib.templ.nodes.Template._flatten (mwlib/templ/nodes.c:5976) File "evaluate.py", line 28, in mwlib.templ.evaluate.flatten (mwlib/templ/evaluate.c:1103) File "evaluate.py", line 30, in mwlib.templ.evaluate.flatten (mwlib/templ/evaluate.c:1134) File "nodes.py", line 210, in mwlib.templ.nodes.Template.flatten (mwlib/templ/nodes.c:4619) File "nodes.py", line 291, in mwlib.templ.nodes.Template._flatten (mwlib/templ/nodes.c:5976) File "evaluate.py", line 30, in mwlib.templ.evaluate.flatten (mwlib/templ/evaluate.c:1134) File "nodes.py", line 52, in mwlib.templ.nodes.IfeqNode.flatten (mwlib/templ/nodes.c:1904) File "evaluate.py", line 28, in mwlib.templ.evaluate.flatten (mwlib/templ/evaluate.c:1103) File "evaluate.py", line 30, in mwlib.templ.evaluate.flatten (mwlib/templ/evaluate.c:1134) File "nodes.py", line 210, in mwlib.templ.nodes.Template.flatten (mwlib/templ/nodes.c:4619) File "nodes.py", line 277, in mwlib.templ.nodes.Template._flatten (mwlib/templ/nodes.c:5777) File "/home/pp/local/lib/python2.6/site-packages/mwlib-0.13.2-py2.6-linux-x86_64.egg/mwlib/templ/magics.py", line 563, in call res = m(args) or '' # FIXME: catch TypeErros File "/home/pp/local/lib/python2.6/site-packages/mwlib-0.13.2-py2.6-linux-x86_64.egg/mwlib/templ/magics.py", line 209, in wrapper return f(self, pagename) File "/home/pp/local/lib/python2.6/site-packages/mwlib-0.13.2-py2.6-linux-x86_64.egg/mwlib/templ/magics.py", line 239, in SUBPAGENAME return pagename.split('/')[-1] AttributeError: 'NoneType' object has no attribute 'split' in function system, file /home/pp/local/lib/python2.6/site-packages/mwlib-0.13.1-py2.6-linux-x86_64.egg/EGG-INFO/scripts/nslave.py, line 63

ralf_wikimedia wrote:

the last one already is on github: https://github.com/pediapress/mwlib/issues/4

ralf_wikimedia wrote:

and for everyone thinking about reporting missing pages/sections: https://github.com/pediapress/mwlib/issues/5

Add Comment