Use of deprecated methods should cause unit tests to fail.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Oct 29 2019, 11:48 AM

Description

Context: wfDeprecated() causes an exception if $wgDeveloperWarnings is set. This causes tests derived from MediaWikiTestCase (resp MediaWikiIntegrationTestCase) to fail when run via MediaWiki's PHPUnit wrapper. However, subclasses of MediaWikiUnitTestCase do not fail on wfDeprecated(), because they do not initialized the $wgDeveloperWarnings variable.

Details

	Subject	Repo	Branch	Lines +/-
	Make deprecated methods fail in unit tests.	mediawiki/core	master	+2 -1

Customize query in gerrit

Event Timeline

daniel created this task.Oct 29 2019, 11:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2019, 11:48 AM

daniel added a subscriber: kostajh.Oct 29 2019, 11:50 AM

Change 546914 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Make deprecated methods fail in unit tests.

https://gerrit.wikimedia.org/r/546914

gerritbot added a project: Patch-For-Review.Oct 29 2019, 11:50 AM

Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Oct 29 2019, 3:38 PM

Anomie moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.

Change 546914 merged by jenkins-bot:
[mediawiki/core@master] Make deprecated methods fail in unit tests.

https://gerrit.wikimedia.org/r/546914

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2019, 8:10 AM

daniel moved this task from Waiting for Review to Done on the Platform Team Workboards (Clinic Duty Team) board.Oct 31 2019, 8:45 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 1 2019, 4:01 PM

Is there anything left to do or this can be closed?

Krinkle closed this task as Resolved.Mar 23 2020, 10:21 PM