1.35.0-wmf.4: Wikilove background image no longer displayed
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DannyS712
	Oct 30 2019, 9:25 PM

Description

Steps to Reproduce:
Visit the user page on a wiki with wikilove installed and mediawiki 1.35.0-wmf.4

Actual Results:
Wikilove link still included, but the image is not properly retrieved. Commons screenshot shown below - the element is still there and still works, and the image is still at the specified url (https://commons.wikimedia.org/w/extensions/WikiLove/resources/images/heart-icons-red.svg?fb578)

Expected Results:
No difference from 1.35.0-wmf.3, in that the wikilove feature still works

Details

	Subject	Repo	Branch	Lines +/-
	Fix vector icon after upstream change	mediawiki/extensions/WikiLove	wmf/1.35.0-wmf.4	+18 -15
	Fix vector icon after upstream change	mediawiki/extensions/WikiLove	master	+18 -15

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	brennen	T233852 1.35.0-wmf.4 deployment blockers
		Resolved	BUG REPORT	Esanders	T236958 1.35.0-wmf.4: Wikilove background image no longer displayed

Event Timeline

DannyS712 created this task.Oct 30 2019, 9:25 PM

Restricted Application added projects: Growth-Team, User-DannyS712. · View Herald TranscriptOct 30 2019, 9:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

"Any open subtask(s) block the train from moving forward.This means no further deployments until the blockers are resolved."

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptOct 30 2019, 9:27 PM

Only patch to WikiLove in wmf.4 is 8319ddb82c029e2145c177c4d85a0e623b3d5dab, which would surprise me to break something like this. Pinging @Esanders, though I'm not sure I think this is an appropriate blocker for the train given the severity and impact.

Esanders added a comment.Oct 30 2019, 9:41 PM

This comment was removed by Esanders.

brennen subscribed.Oct 30 2019, 9:44 PM

This was broken by a change in Vector: https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/545904/

cc @Krinkle, @matmarex, @Volker_E

My sense is that this may or may not block tomorrow's promotion to group2, but probably does not warrant rolling back group1 at present?

I don't think it blocks group2, and it definitely doesn't need a group1 rollback.

Might also have been caused by tweaks to Vector (legacy skin)? E.g. a5fe72696b648d77c3a333d0e4fe4fa51df40837 feels suspect.

Looks like WikiLove was already targeting the correct element (in that, it was not relying on the existence of <span> elements).

However, it was broken by an earlier commit in which Volker and I re-implemented the background images using 1px wide gradient. The background-size rule for that gradient is now applying to the WikiLove <a> element. Here is a screenshot of the tab bar with that rule disabled:

Screenshot 2019-10-30 at 18.01.49.png (1×1 px, 263 KB)

This rule could be disabled by WikiLove, but that would still mean that the separator line between WikiLove and watchstar will be missing.

Instead of that, we should probably do the long-overdue update to WikiLove to make it's icon logic match that of Vector, by using ::before instead to render the icon.

Change 547331 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikiLove@master] Fix vector icon after upstream change

https://gerrit.wikimedia.org/r/547331

gerritbot added a project: Patch-For-Review.Oct 30 2019, 10:14 PM

Change 547331 merged by jenkins-bot:
[mediawiki/extensions/WikiLove@master] Fix vector icon after upstream change

https://gerrit.wikimedia.org/r/547331

Change 547361 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/WikiLove@wmf/1.35.0-wmf.4] Fix vector icon after upstream change

https://gerrit.wikimedia.org/r/547361

Change 547361 merged by jenkins-bot:
[mediawiki/extensions/WikiLove@wmf/1.35.0-wmf.4] Fix vector icon after upstream change

https://gerrit.wikimedia.org/r/547361

Mentioned in SAL (#wikimedia-operations) [2019-10-31T00:40:57Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.4/extensions/WikiLove/resources/ext.wikiLove.icon.vector.css: T236958 Fix Vector icon after upstream change (duration: 01m 02s)