Page MenuHomePhabricator

Next, previous and index tabs on Wikisource are broken in Vector
Closed, ResolvedPublicBUG REPORT

Description

In the page namespace in Wikisource, there are tabs leading to the previous page, the next page and the related index page. They used to be indicated by arrows left, right and up respectively, but since the last MediaWiki train, they have instead shown the tab separator background instead.

The arrows are specified as CSS backgrounds on the tab's a element, and I believe this change by @Krinkle is what causes the breakage, since the tab separator is now specified on the same a element, overriding the CSS from ProofreadPage that sets the arrow backgrounds.

Possible solution: Add a span tag in the code for the ProofreadPage tabs, and add the arrow backgrounds to that element instead.

Details

Related Gerrit Patches:

Event Timeline

jhsoby created this task.Wed, Oct 30, 11:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Oct 30, 11:06 PM
jhsoby changed the subtype of this task from "Task" to "Bug Report".Wed, Oct 30, 11:22 PM

I was about to create a report for the same problem...

Tpt triaged this task as High priority.EditedThu, Oct 31, 8:53 AM
Tpt added a subscriber: Tpt.

Priority set to high: breaks the UI of all Wikisource Page: pages on the default skin.

I'm currently trying to reproduce the problem on by development instance

Tpt moved this task from Backlog to Top priority on the ProofreadPage board.Thu, Oct 31, 8:54 AM
Xover added a subscriber: Xover.Thu, Oct 31, 9:11 AM

Change 547490 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/ProofreadPage@master] Makes sure that Vector default background does not override the navigation arrows

https://gerrit.wikimedia.org/r/547490

Tpt added a subscriber: Isarra.Thu, Oct 31, 9:37 AM

I just made a change that should fix the problem: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/547490
It is based on a fix for Timeless by @Isarra (thank you!) that I just merged: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/533327/3

Change 547490 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Makes sure that Vector default background does not override the navigation arrows

https://gerrit.wikimedia.org/r/547490

Change 547498 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/ProofreadPage@wmf/1.35.0-wmf.4] Makes sure that Vector default background does not override the navigation arrows

https://gerrit.wikimedia.org/r/547498

Change 547498 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@wmf/1.35.0-wmf.4] Makes sure that Vector default background does not override the navigation arrows

https://gerrit.wikimedia.org/r/547498

Mentioned in SAL (#wikimedia-operations) [2019-10-31T11:23:19Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.4/extensions/ProofreadPage/: SWAT: e0d5ce9: Add page navigation tabs in correct order skin-side and remove js requirement for Vector tab icons (T231250); ed17da2: Makes sure that Vector default background does not override the navigation arrows (T236969) (duration: 01m 02s)

Tpt closed this task as Resolved.Thu, Oct 31, 11:30 AM
Tpt claimed this task.

Change deployed on Wikisource.