Page MenuHomePhabricator
Create Task
Maniphest T237528

Create permission error component
Closed, ResolvedPublic
Actions

Description

The component should take into consideration that there might be more than one reason for the denied permission.
The component should at least consist of:

  • a title
  • a section holding information about the different permissions being denied
  • each permission statement could be its own component, holding an expandable text with more information.

Please refer to the design mocks.

Details

SubjectRepoBranchLines +/-
bridge: Fix style issues with permission errors screenmediawiki/extensions/Wikibasemaster+75 -22
bridge: add story for ErrorPermissionmediawiki/extensions/Wikibasemaster+43 -0
bridge: Add ErrorPermission.vue to Storybookmediawiki/extensions/Wikibasemaster+28 -0
bridge: test PageList & document intentmediawiki/extensions/Wikibasemaster+84 -6
bridge: Convert the cascade pages array to an html listmediawiki/extensions/Wikibasemaster+315 -44
bridge: Change the way cascade protected pages are passed to permission errorsmediawiki/extensions/Wikibasemaster+18 -43
bridge: Introduce permission error componentmediawiki/extensions/Wikibasemaster+719 -1
bridge: Add entityTitle to root storemediawiki/extensions/Wikibasemaster+49 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Nov 6 2019, 12:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2019, 12:08 PM
Addshore subscribed.Nov 6 2019, 2:35 PM
• Pablo-WMDE moved this task from Incoming to Task overflow on the Wikidata-Bridge board.Nov 6 2019, 3:09 PM
• Matthias_Geisler_WMDE edited projects, added Wikidata-Bridge-Sprint-9; removed Wikidata-Bridge.Nov 18 2019, 12:24 PM
• Matthias_Geisler_WMDE claimed this task.Nov 19 2019, 1:51 PM
• Matthias_Geisler_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-9 board.
• Matthias_Geisler_WMDE moved this task from Doing to To do on the Wikidata-Bridge-Sprint-9 board.
• Matthias_Geisler_WMDE removed • Matthias_Geisler_WMDE as the assignee of this task.Nov 19 2019, 1:53 PM
• Matthias_Geisler_WMDE subscribed.
darthmon_wmde added a project: Wikidata-Bridge-Sprint-10.Nov 20 2019, 9:59 AM
• Tonina_Zhelyazkova_WMDE claimed this task.Dec 3 2019, 10:21 AM
• Tonina_Zhelyazkova_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-10 board.
• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)Dec 3 2019, 2:38 PM
gerritbot added a comment.Dec 3 2019, 2:54 PM

Change 554301 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] data-bridge: Introduce permission error component

https://gerrit.wikimedia.org/r/554301

gerritbot added a project: Patch-For-Review.Dec 3 2019, 2:54 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Bridge-Sprint-11.Dec 4 2019, 9:59 AM
Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-11 board.Dec 4 2019, 9:59 AM
• Pablo-WMDE mentioned this in T241823: Dispatch combined permission service when application is started.Jan 9 2020, 8:54 AM
darthmon_wmde added a project: Wikidata-Bridge-Sprint-12.Jan 15 2020, 10:02 AM
darthmon_wmde moved this task from To do to Doing on the Wikidata-Bridge-Sprint-12 board.
• Pablo-WMDE mentioned this in T239798: Support client permission error in ErrorPermission component.Jan 15 2020, 11:09 AM
• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-11 board.Jan 16 2020, 12:57 PM
• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-12 board.Jan 16 2020, 1:35 PM
gerritbot added a comment.Jan 16 2020, 1:59 PM

Change 565274 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Add entityTitle to root store

https://gerrit.wikimedia.org/r/565274

gerritbot added a comment.Jan 16 2020, 3:35 PM

Change 565274 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Add entityTitle to root store

https://gerrit.wikimedia.org/r/565274

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 16 2020, 4:00 PM
gerritbot added a comment.Jan 16 2020, 5:01 PM

Change 554301 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Introduce permission error component

https://gerrit.wikimedia.org/r/554301

Maintenance_bot removed a project: Patch-For-Review.Jan 16 2020, 5:10 PM
• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-12 board.Jan 17 2020, 9:37 AM
gerritbot added a comment.Jan 17 2020, 11:30 AM

Change 565533 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Change the way cascade protected pages are passed to permission errors

https://gerrit.wikimedia.org/r/565533

gerritbot added a project: Patch-For-Review.Jan 17 2020, 11:30 AM
gerritbot added a comment.Jan 17 2020, 3:10 PM

Change 565533 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Change the way cascade protected pages are passed to permission errors

https://gerrit.wikimedia.org/r/565533

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2020, 3:10 PM
gerritbot added a comment.Jan 17 2020, 3:17 PM

Change 565610 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Convert the cascade pages array to an html list

https://gerrit.wikimedia.org/r/565610

gerritbot added a project: Patch-For-Review.Jan 17 2020, 3:17 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 20 2020, 6:42 PM
Lucas_Werkmeister_WMDE reopened this task as Open.
Lucas_Werkmeister_WMDE moved this task from Done to Peer Review on the Wikidata-Bridge-Sprint-12 board.
Lucas_Werkmeister_WMDE subscribed.

Nevermind, I missed the above Gerrit change, which is still open.

gerritbot added a comment.Jan 21 2020, 6:17 PM

Change 565610 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Convert the cascade pages array to an html list

https://gerrit.wikimedia.org/r/565610

gerritbot added a comment.Jan 21 2020, 6:20 PM

Change 566331 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: test PageList & document intent

https://gerrit.wikimedia.org/r/566331

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.18; 2020-02-04); removed MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 21 2020, 7:01 PM
gerritbot added a comment.Jan 22 2020, 10:38 AM

Change 566331 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: test PageList & document intent

https://gerrit.wikimedia.org/r/566331

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2020, 11:10 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 22 2020, 11:44 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-12 board.
gerritbot added a comment.Jan 22 2020, 2:14 PM

Change 566526 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Add ErrorPermission.vue to Storybook

https://gerrit.wikimedia.org/r/566526

gerritbot added a project: Patch-For-Review.Jan 22 2020, 2:14 PM

Change 566527 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Fix style issues with permission errors screen

https://gerrit.wikimedia.org/r/566527

gerritbot added a comment.Jan 24 2020, 11:43 AM

Change 566804 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add story for ErrorPermission

https://gerrit.wikimedia.org/r/566804

gerritbot added a comment.Jan 24 2020, 12:41 PM

Change 566526 abandoned by Pablo Grass (WMDE):
bridge: Add ErrorPermission.vue to Storybook

Reason:
Discontinued in favor of I0cf0cfee20d3a87330cd2354d804a846146a0455

https://gerrit.wikimedia.org/r/566526

gerritbot added a comment.Jan 24 2020, 1:04 PM

Change 566804 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add story for ErrorPermission

https://gerrit.wikimedia.org/r/566804

gerritbot added a comment.Jan 24 2020, 4:02 PM

Change 566527 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Fix style issues with permission errors screen

https://gerrit.wikimedia.org/r/566527

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2020, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL