Step 1: bail-out path for deprecated main snaks (impact: medium)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Lydia_Pintscher
	Nov 19 2019, 3:32 PM

Description

As an editor I want to be able to edit all data that is shown to me in the Bridge.

Problem:
We don't support editing of all ranks. We need to allow a bail-out to Wikidata for this case so the editors can still edit this data.

Screenshots/mockups:

BDD
GIVEN a statement with a deprecated value
WHEN trying to edit it
THEN a message is shown leading the editor to edit on the repository instead

Acceptance criteria:

trying to edit a statement with a deprecated value results in a screen telling the editor to go to the repository
hierarchy of bail-outs is datatype -> multiple values -> special value -> rank

Details

	Subject	Repo	Branch	Lines +/-
	bridge: fix vertical marging of bailout heading	mediawiki/extensions/Wikibase	master	+11 -9
	bridge: show property labels in bailout components	mediawiki/extensions/Wikibase	master	+498 -185

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T228066 Step 1: Error States of Data-Bridge [Tracking] (impact: medium)
Resolved	Charlie_WMDE	T238660 Step 1: bail-out path for deprecated main snaks (impact: medium)
Resolved	Lucas_Werkmeister_WMDE	T243888 Restrict editing to normal- and preferred-rank statements
Resolved	• Tonina_Zhelyazkova_WMDE	T243889 Display error and bail-out for deprecated statements
Resolved	Lucas_Werkmeister_WMDE	T244342 Reduce duplication in bail-out errors

Event Timeline

Lydia_Pintscher created this task.Nov 19 2019, 3:32 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptNov 19 2019, 3:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Assigning to Charlie to figure out how the interaction should work.

Lydia_Pintscher renamed this task from Wikidata Ticket Template to bail-out path for individual snaks.Nov 19 2019, 3:35 PM

Charlie_WMDE updated the task description. (Show Details)Nov 28 2019, 3:19 PM

Charlie_WMDE updated the task description. (Show Details)Dec 2 2019, 9:28 AM

Charlie_WMDE updated the task description. (Show Details)

Lydia_Pintscher renamed this task from bail-out path for individual snaks to Step 1: bail-out path for individual snaks.Dec 5 2019, 1:11 PM

Based on last weeks discussion: rewrite this to handle these cases in the same way we handle not being able to edit the data type of the main snak.

Lydia_Pintscher renamed this task from Step 1: bail-out path for individual snaks to Step 1: bail-out path for novalue/somevalue in the main snak and deprecated main snaks.Dec 8 2019, 12:08 PM

Lydia_Pintscher renamed this task from Step 1: bail-out path for novalue/somevalue in the main snak and deprecated main snaks to Step 1: bail-out path for novalue/somevalue in the main snak and deprecated main snaks (impact: medium).Dec 8 2019, 1:21 PM

Addshore moved this task from incoming to in progress on the Wikidata board.Dec 11 2019, 11:47 AM

Lydia_Pintscher added a parent task: T228066: Step 1: Error States of Data-Bridge [Tracking] (impact: medium).Dec 19 2019, 10:24 AM

@Lydia_Pintscher please have a look if this is ready for story writing

Lydia_Pintscher updated the task description. (Show Details)Jan 12 2020, 1:24 PM

Jep :)
One issue in the text for the deprecated path: It says the Property is deprecated but what is actually deprecated is the value. (Deprecating a Property means the editor is no longer supposed to use that particular Property in any statement.)

Charlie_WMDE updated the task description. (Show Details)Jan 13 2020, 10:16 AM

@Lydia_Pintscher fixed. thank you for the feedback.

Charlie_WMDE updated the task description. (Show Details)Jan 14 2020, 11:16 AM

darthmon_wmde updated the task description. (Show Details)Jan 14 2020, 11:16 AM

darthmon_wmde updated the task description. (Show Details)Jan 14 2020, 11:21 AM

Lydia_Pintscher renamed this task from Step 1: bail-out path for novalue/somevalue in the main snak and deprecated main snaks (impact: medium) to Step 1: bail-out path for deprecated main snaks (impact: medium).Jan 14 2020, 1:09 PM

Lydia_Pintscher updated the task description. (Show Details)

Lydia_Pintscher set the point value for this task to 8.

Lydia_Pintscher moved this task from Ready for story writing to Ready to pick up on the Wikidata-Bridge board.

Charlie_WMDE removed Charlie_WMDE as the assignee of this task.Jan 28 2020, 12:15 PM

Charlie_WMDE subscribed.

Lucas_Werkmeister_WMDE closed subtask T243888: Restrict editing to normal- and preferred-rank statements as Resolved.Feb 3 2020, 4:52 PM

• Tonina_Zhelyazkova_WMDE edited projects, added Wikidata-Bridge-Sprint-13; removed Wikidata-Bridge.Feb 4 2020, 12:22 PM

• Tonina_Zhelyazkova_WMDE edited projects, added Wikidata-Bridge; removed Wikidata-Bridge-Sprint-13.

• Tonina_Zhelyazkova_WMDE edited projects, added Wikidata-Bridge-Sprint-13; removed Wikidata-Bridge.Feb 4 2020, 12:24 PM

• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)Feb 4 2020, 2:13 PM

• Tonina_Zhelyazkova_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-13 board.Feb 4 2020, 3:35 PM

Should the heading really be “Editing the value for $property is not supported”? That’s the same heading as for unsupported datatypes (T235753), but in this case, the problem isn’t the property, it’s the particular statement.

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-13 board.Feb 4 2020, 4:15 PM

In T238660#5848511, @Lucas_Werkmeister_WMDE wrote:

Should the heading really be “Editing the value for $property is not supported”? That’s the same heading as for unsupported datatypes (T235753), but in this case, the problem isn’t the property, it’s the particular statement.

In theory something to think about. But there's an upcoming ticket (not created yet) with text changes to the bail-out paths so I'd wait with discussing any further changes until we have it in story writing.

• Tonina_Zhelyazkova_WMDE closed subtask T243889: Display error and bail-out for deprecated statements as Resolved.Feb 6 2020, 10:18 AM

Lucas_Werkmeister_WMDE closed subtask T244342: Reduce duplication in bail-out errors as Resolved.Feb 6 2020, 10:55 AM

Change 570634 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: WIP: show property labels in bailout components

https://gerrit.wikimedia.org/r/570634

gerritbot added a project: Patch-For-Review.Feb 6 2020, 3:04 PM

Change 570634 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: show property labels in bailout components

https://gerrit.wikimedia.org/r/570634

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2020, 4:11 PM

Change 570921 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: fix vertical marging of bailout heading

https://gerrit.wikimedia.org/r/570921

gerritbot added a project: Patch-For-Review.Feb 7 2020, 4:38 PM

Change 570921 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: fix vertical marging of bailout heading

https://gerrit.wikimedia.org/r/570921

Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-13 board.Feb 7 2020, 5:23 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2020, 6:11 PM

looks good!

	F31512089: unknownValue.png
	Jan 14 2020, 11:16 AM

	F31512091: NoValue.png
	Jan 14 2020, 11:16 AM

	F31512087: deprecatedValue.png
	Jan 14 2020, 11:16 AM

	F31510517: deprecatedValue.png
	Jan 13 2020, 10:16 AM

Step 1: bail-out path for deprecated main snaks (impact: medium)Closed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

Step 1: bail-out path for deprecated main snaks (impact: medium)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Related Objects
Search...