Implement service to get permission errors for editing a page
Closed, ResolvedPublic
Actions

Description

See T237522#5672429 for investigation results. Note that this is the service for a single wiki – errors from the repo and client wiki are combined elsewhere.

Ideally, we would combine this with other action=query API calls, but I think that doesn’t have to be in the initial version.

page protected
page cascade-protected
user blocked
unknown error

Details

Subject	Repo	Branch	Lines +/-
bridge: Detect the user being blocked on repo or client	mediawiki/extensions/Wikibase	master	+182 -3
bridge: detect cascade-protected errors	mediawiki/extensions/Wikibase	master	+196 -10
bridge: define and implement PageEditPermissionErrorsRepository	mediawiki/extensions/Wikibase	master	+536 -14

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T228066 Step 1: Error States of Data-Bridge [Tracking] (impact: medium)
Resolved	• Tonina_Zhelyazkova_WMDE	T235154 show error when editor can't edit the statement because of permission errors on the repository
Resolved	Lucas_Werkmeister_WMDE	T239336 Implement service to get permission errors for editing a page
Open	None	T240565 Expose own IP address in API

Event Timeline

Lucas_Werkmeister_WMDE created this task.Nov 27 2019, 1:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 27 2019, 1:24 PM

Lucas_Werkmeister_WMDE claimed this task.Nov 27 2019, 1:25 PM

Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-10 board.

Change 553347 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: WIP: define and implement PageEditPermissionErrorsRepository

https://gerrit.wikimedia.org/r/553347

gerritbot added a project: Patch-For-Review.Nov 27 2019, 2:35 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-10 board.Nov 27 2019, 5:09 PM

Ideally, we would combine this with other action=query API calls, but I think that doesn’t have to be in the initial version.

A proposal for how to implement this is now at https://gerrit.wikimedia.org/r/553394.

Lucas_Werkmeister_WMDE mentioned this in T239710: Implement service to combine permission errors from repo and client.Dec 3 2019, 1:21 PM

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Bridge-Sprint-11; removed Wikidata-Bridge-Sprint-10.Dec 4 2019, 9:57 AM

Lucas_Werkmeister_WMDE moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-11 board.

• Pablo-WMDE added a project: Wikidata-Bridge-Sprint-10.Dec 4 2019, 9:58 AM

• Pablo-WMDE mentioned this in T239797: Wire up client permission service.Dec 4 2019, 11:07 AM

@Lucas_Werkmeister_WMDE mentioned during the task break-down that we still need to check for blocking as a permission problem, add it to the output.

Change 553347 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: define and implement PageEditPermissionErrorsRepository

https://gerrit.wikimedia.org/r/553347

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 4 2019, 4:00 PM

Unassigning myself in case someone else wants to tackle block errors.

Lucas_Werkmeister_WMDE removed a project: Patch-For-Review.Dec 9 2019, 1:30 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

I’ll do the cascade protection part next.

Change 556013 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: detect cascade-protected errors

https://gerrit.wikimedia.org/r/556013

gerritbot added a project: Patch-For-Review.Dec 9 2019, 6:27 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 9 2019, 6:30 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-11 board.

Addshore moved this task from incoming to in progress on the Wikidata board.Dec 11 2019, 11:47 AM

Lucas_Werkmeister_WMDE mentioned this in T237526: create messages according to mocks.Dec 11 2019, 5:16 PM

Lucas_Werkmeister_WMDE added a subtask: T240565: Expose own IP address in API.Dec 12 2019, 12:57 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 13 2019, 12:23 PM

Change 556419 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Detect the user being blocked on repo or client

https://gerrit.wikimedia.org/r/556419

Michael updated the task description. (Show Details)Dec 13 2019, 2:16 PM

Change 556013 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: detect cascade-protected errors

https://gerrit.wikimedia.org/r/556013

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 13 2019, 4:17 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.11; 2019-12-17); removed MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 13 2019, 5:00 PM

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 13 2019, 5:12 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-11 board.

Change 556419 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Detect the user being blocked on repo or client

https://gerrit.wikimedia.org/r/556419

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2019, 6:10 PM