Page MenuHomePhabricator

AfD tagging behaving inconsistently
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

I am seeing some weird behaviour when tagging an article with AfD.

Including:

  1. In some cases, the {{afd}} template is added twice to the page (see T230455#5661483 and T230455#5673920). See https://test.wikipedia.org/wiki/Dsjfklsdjl. Looking in the revision history, it looks like the same edit is being made twice.
  2. In others, when the page has previously been tagged AfD, the subsequent nominations functionality (implemented T231357) does not work. See https://test.wikipedia.org/wiki/Drwpb_New_Page_1.
  3. The subsequent nomination feature fails to create the Wikipedia:Articles_for_deletion/$article_(nth_nomination). See the top AfD nomination here: https://test.wikipedia.org/wiki/Drwpb_New_Page_1.
  4. I don't think the AfD tag is being logged. See https://en.wikipedia.org/wiki/Special:Log?type=pagetriage-curation&user=&page=Zalki, the article Zalki has been marked AfD. It was working previously, example.

I also often see error popups when tagging AfD, including "Failed to notify author", "Failed to apply tag" and "Failed to find target spot for discussion".

Steps to reproduce problem
  1. Go to Special:NewPageFeed and click on a page
  2. Click the bin/delete icon, click "Articles for Deletion"
  3. Fill in the text input, click "Add Details", click "Mark for Deletion"

Expected behavior:

  • An AfD tag should be added to the page once.
    • If it is a subsequent nomination, the tag should be numbered appropriately.
  • An entry should be made in Wikipedia:Articles_for_deletion/Log/$today's_date
  • A new page should be created Wikipedia:Articles_for_deletion/$article_title
    • Or, for subsequent nominations, Wikipedia:Articles_for_deletion/$article_title_(nth_Nomination)
  • Some sort of message should appear on the User_talk of the creator of the page
  • There should be an entry recording the AfD tag in Special:Log?type=pagetriage-curation (e.g. marked $article_title for deletion with afd tag)

Observed behavior: See problems listed above.

Environment

Browser: Firefox 68
Wiki(s): Last reproduced: https://test.wikipedia.org MediaWiki 1.35.0-wmf.8 (rMWf20930f9c7d3) 18:32, 26 November 2019; PageTriage 0.3.0 (fec0b93) 08:24, 18 November 2019

Event Timeline

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript

It seems that this bug has never been processed. It's driving reviewers away from the process just when NPP has a massive backlog and needs all the help it can get. Would it be possible to do something about it now? @MarioGom , @Joe Roe , @DanCherek , @MusikAnimal

Anyone is free to investigate. (Please do not ping random folks. Thank you.)

Change 814350 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Fix AFD and PROD bugs

https://gerrit.wikimedia.org/r/814350

Change 814350 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fix AFD and PROD bugs

https://gerrit.wikimedia.org/r/814350

I probably need to test all 4 of the bugs in this ticket separately and see if they are reproducible. Then make separate bug reports and close this ticket.

  1. {{afd}} added twice - is probably fixed by https://gerrit.wikimedia.org/r/814294
  2. previous AFD being broken all the time, or being the cause of # 3 - worth investigating, I made a note in T238025
  3. AFD page not created - duplicate of T238025
  4. AFD never logged in page curation log - needs testing, if not reproducible 100% of the time, then likely correlates with # 3

Closing for now. I think a lot of these were solved by various patches. If any of these are still an issue, please create a new ticket, one ticket per issue.

Novem_Linguae claimed this task.
Novem_Linguae moved this task from Soon to Done on the PageTriage board.