Page MenuHomePhabricator

Page Curation should create a new AfD discussion page if one already exists
Open, Needs TriagePublic5 Story Points

Description

As a Page Curation user, I want to see distinctly named AfD discussion pages (per each AfD discussion), so that I can easily find and track all AfD discussions.

Note: The investigation of this work can be found in T169441.

Acceptance Criteria:

Details

Related Gerrit Patches:
mediawiki/extensions/PageTriage : masterFix finding deletion subpages for MfD
mediawiki/extensions/PageTriage : masterNumbered discussion pages

Event Timeline

ifried created this task.Aug 27 2019, 4:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2019, 4:47 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 27 2019, 4:47 PM
ifried renamed this task from Placeholder: Page Curation should create a new AfD discussion page if one already exists to Page Curation should create a new AfD discussion page if one already exists.Aug 27 2019, 10:19 PM
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)Aug 27 2019, 10:52 PM
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried set the point value for this task to 5.Aug 27 2019, 11:30 PM
kostajh moved this task from Inbox to External on the Growth-Team board.Aug 28 2019, 7:14 AM
kostajh added a subscriber: kostajh.

Appears that Community-Tech is working on this.

MaxSem claimed this task.Aug 28 2019, 5:18 PM
MaxSem moved this task from Ready to In Development on the Community-Tech (Kanban (Q1 2019-20)) board.

Change 535725 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/PageTriage@master] WIP: Numbered discussion pages

https://gerrit.wikimedia.org/r/535725

What is the actual progress on this?
The script didn't work today - it only completed half the job and then put some of the elements on the wrong pages. Relying on Twinkle (which works) as a backup system is not a solution for me.

This task is not yet complete but I know it's being worked on at another task which I can't immediately locate.

aezell added a subscriber: aezell.Oct 7 2019, 5:14 PM

I've +2ed this patch.

Change 535725 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Numbered discussion pages

https://gerrit.wikimedia.org/r/535725

@MaxSem I cannot get this to work on beta for Miscellany for Deletion (for User namespace pages).

My speculation. The API request looks like:

action=query
format=json
titles=Wikipedia:Miscellany_for_deletion/User:Drwpb
list=allpages
apnamespace=4
apprefix=Miscellany for deletion/User:Drwpb (
aplimit=max
formatversion=2

(notice the titles parameter has underscores not spaces, set here?)

But the response is of the form:

{
...
  "pages": [
    {
      "pageid": 197068,
      "ns": 4,
      "title": "Wikipedia:Miscellany for deletion/User:Drwpb"
    }
  ]
...
}

(notice spaces rather than underscores)

When we do the comparison here, "Wikipedia:Miscellany for deletion/User:Drwpb" and "Wikipedia:Miscellany_for_deletion/User:Drwpb" do not match.

Change 541660 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/PageTriage@master] Fix finding deletion subpages for MfD

https://gerrit.wikimedia.org/r/541660

Thanks Don - this is indeed the case! The above fix is ready for review.

As far as i can see, the request is for use with the Curation toolbar that can only be used by New Page reviewers, and therefore only concerns AfD for new mainspace articles and not the various MfD venues for other mainspaces. Twinkle works for those others.

Change 541660 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Fix finding deletion subpages for MfD

https://gerrit.wikimedia.org/r/541660

For AfD:
https://en.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Articles_for_deletion/Drwpb_Random_New_Page_1
https://en.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Articles_for_deletion/Drwpb_Random_New_Page_1_(2nd_nomination)

For MfD (in the User namespace):
https://en.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Miscellany_for_deletion/User:Drwpb/Foobar
https://en.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Miscellany_for_deletion/User:Drwpb/Foobar_(2nd_nomination)

@ifried The message that gets sent to the creator's User_talk page always includes the link to the first discussion page, even if this is a subsequent nomination.

I believe this is something the community can change in the templates.

For AfD, we send this wikitext to User_talk: {{subst:AfD-notice-NPF|Drwpb+Random+New+Page+1|Drwpb+Random+New+Page+1+(31st+nomination)}}~~~~, which uses this template: https://en.wikipedia.org/wiki/Template:AfD-notice-NPF.

For MfD, we send this wikitext: {{subst:MFDWarning-NPF|User:Drwpb/Foobar|User:Drwpb/Foobar+(2nd+nomination)}} ~~~~, which uses this template: https://en.wikipedia.org/wiki/Template:MFDWarning-NPF.

I believe the first patch in this task, which enabled it for AfD, is on production (or will be in the next couple of days). The second, which fixes the issue for MfD, I think just missed the train.

Production templates are already prepared.

Production templates are already prepared.

Sure, but they still appear to link to the first discussion page (for example, they use [[Wikipedia:Articles for deletion/{{{1}}} ]] when they should probably use [[Wikipedia:Articles for deletion/{{{2}}} ]]).

@Barkeep49 @Insertcleverphrasehere @DannyS712 This change should now be live. When you get a chance, could you test it out & let us know if it's functioning as expected? Thank you!

Pinging @Barkeep49 again, since this ping may have been lost in a sea of other pings and requests: This change should now be live. When you get a chance, could you test it out & let us know if it's functioning as expected? Thank you!

SD0001 added a subscriber: SD0001.Fri, Nov 1, 12:12 AM

It looks as if PageCuration is preemptively making an API call for getting prior AfD/MfD nomination page names on every single page (even on pages not in the new pages feed, and even in namespaces where it is not required). This isn't exactly a good idea performance-wise, is it? Shouldn't this be delayed until the user actually tries to mark the page for deletion?

It looks as if PageCuration is preemptively making an API call for getting prior AfD/MfD nomination page names on every single page (even on pages not in the new pages feed, and even in namespaces where it is not required). This isn't exactly a good idea performance-wise, is it? Shouldn't this be delayed until the user actually tries to mark the page for deletion?

Can you try loading a page with ?safemode=1 in the URL? Do you still see that API call being made?

It's a wild guess, but I was wondering if what you're seeing is from https://meta.wikimedia.org/wiki/MoreMenu, which looks for AfD/MfD on every page, and maybe you misattributed the API call to Page Curation? I don't see any such API calls being made when in safemode.

Pinging @Barkeep49 again, since this ping may have been lost in a sea of other pings and requests: This change should now be live. When you get a chance, could you test it out & let us know if it's functioning as expected? Thank you!

Confirmed with https://en.wikipedia.org/wiki/Wikipedia:Articles_for_deletion/Francis_E._Dec_(3rd_nomination)

MaxSem added a comment.Fri, Nov 1, 4:57 AM

@dom_walden, looking at the above nomination:

Templates look to be working to me.

SD0001 added a comment.Fri, Nov 1, 5:44 AM

It's a wild guess, but I was wondering if what you're seeing is from https://meta.wikimedia.org/wiki/MoreMenu, which looks for AfD/MfD on every page, and maybe you misattributed the API call to Page Curation? I don't see any such API calls being made when in safemode.

Thanks, that'd it. I didn't realise (i) that PageCuration itself would work in safemode as its JS-based, but makes sense as it's an extension (ii) that MoreMenu listed XfDs.

SD0001 added a comment.Fri, Nov 1, 5:48 AM

@dom_walden, looking at the above nomination:

Templates look to be working to me.

Log page edit summary was not there before (but probably should be - that'd be a different task though).

In edit summary while tagging the page itself - name of the template used ought to have been there in the brackets.

@dom_walden, looking at the above nomination:

Templates look to be working to me.

Oh, you're right. The templates didn't look right to me. Nevermind.