Page MenuHomePhabricator
Create Task
Maniphest T241207

Decommission Parsoid/JS from the Wikimedia cluster
Closed, ResolvedPublic
Actions

Description

Now that Parsoid/PHP is live on the cluster, we can start taking steps to decommission Parsoid/JS from the cluster.

However, note that nodejs is still required on scandium since rt-testing and other testing tools are still node.js based.

We can either create specific steps here or create subtasks.

Let us deploy changes and update the cluster in the new year

Details

SubjectRepoBranchLines +/-
scap/dsh: remove parsoid service, replaced by parsoid-phpoperations/puppetproduction+0 -3
conftool: remove parsoid, keep parsoid-phpoperations/puppetproduction+44 -44
Customize query in gerrit

Related Objects
Search...

Event Timeline

ssastry triaged this task as Medium priority.Dec 20 2019, 7:48 AM
ssastry created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2019, 7:48 AM
ssastry mentioned this in T229015: Tracking: Direct live production traffic at Parsoid/PHP.Dec 20 2019, 7:50 AM
gerritbot added a comment.Dec 20 2019, 9:06 AM

Change 559705 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] conftool: remove parsoid, keep parsoid-php

https://gerrit.wikimedia.org/r/559705

gerritbot added a project: Patch-For-Review.Dec 20 2019, 9:06 AM
ssastry updated the task description. (Show Details)Dec 20 2019, 3:09 PM
Bugreporter mentioned this in T241377: Merge Parsoid and Parsoid-PHP project.Dec 23 2019, 6:14 PM
ssastry mentioned this in T241202: ServiceChecker still calls Parsoid/JS.Jan 9 2020, 6:49 AM
• Pchelolo added a subtask: T241756: Clean-up Parsoid-PHP transition code from RESTBase.Jan 9 2020, 3:37 PM
Jdforrester-WMF subscribed.Jan 9 2020, 6:03 PM
ssastry mentioned this in T242430: Undeploy ParsoidBatchAPI from the Wikimedia cluster.Jan 10 2020, 1:48 PM
ssastry added a parent task: T242430: Undeploy ParsoidBatchAPI from the Wikimedia cluster.
Jdforrester-WMF added a subtask: T242782: Stop running Parsoid-JS tests in CI.Jan 14 2020, 9:46 PM
• Pchelolo closed subtask T241756: Clean-up Parsoid-PHP transition code from RESTBase as Resolved.Feb 5 2020, 7:53 PM
Arlolra moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Feb 14 2020, 11:39 PM
Joe added a project: serviceops.Aug 26 2020, 3:23 PM
gerritbot added a comment.Aug 26 2020, 6:27 PM

Change 559705 abandoned by Dzahn:
[operations/puppet@production] conftool: remove parsoid, keep parsoid-php

Reason:

https://gerrit.wikimedia.org/r/559705

Aklapper removed a subscriber: serviceops.Sep 18 2020, 7:53 AM
Jdforrester-WMF closed this task as Resolved.Jan 5 2021, 5:19 PM

This is definitely done now.

Dzahn subscribed.Jan 6 2021, 12:38 AM

@Jdforrester-WMF I don't think it fully is, honestly.

for example conftool-data has the old parsoid service:

eqiad.yaml: wtp1040.eqiad.wmnet: [parsoid, parsoid-php]

Dzahn added a comment.Jan 6 2021, 12:40 AM

Also, nodejs is running:

@wtp1025:~# ps aux | grep nodejs  | wc -l
52
Jdforrester-WMF reopened this task as Open.Jan 6 2021, 5:42 PM

Ah, oops, we should clean that up, certainly.

Krinkle added subscribers: hashar, Krinkle.May 2 2022, 4:30 PM
In T307349#7895622, @hashar wrote:

I checked the HEAD of all git repos under /srv/deployment […]

Comparison between deploy2002 and deploy1002:

$ colordiff -U0 --text deploy2002 deploy1002 
--- deploy2002	2022-05-02 14:33:48.321048639 +0200
+++ deploy1002	2022-05-02 14:33:49.585064545 +0200
@@ -88 +87,2 @@
-/srv/deployment/parsoid/config/node_modules/events/@modules/raw.github.com/Gozala/extendables/v0.2.0/.git/srv/deployment/parsoid/config/.gitf12b09d5dfeb18c74104a5cdefc7ec4ea23a2b2a
+/srv/deployment/parsoid/config/.gitf12b09d5dfeb18c74104a5cdefc7ec4ea23a2b2a
+/srv/deployment/parsoid/config/node_modules/events/@modules/raw.github.com/Gozala/extendables/v0.2.0/.git/srv/deployment/ores/deploy/submodules/assets/.git08b9cebc5e0148ace73915a94e65a5dd0f0ba9a2

The presence of /srv/deployment/parsoid/config/node_modules looks like a left-over of Parsoid JS that probably can or should at some point be decom'ed. Leaving here as reminder and/or to clarify otherwise.

Maintenance_bot removed a project: Patch-For-Review.May 2 2022, 4:31 PM
Dzahn added a comment.May 2 2022, 4:38 PM

To a certain extent a duplicate of T279059 which we just closed.

Dzahn added a subtask: T279059: Remove parsoidJS leftovers from production.May 2 2022, 4:38 PM
Dzahn mentioned this in T279059: Remove parsoidJS leftovers from production.May 2 2022, 6:09 PM
hashar unsubscribed.Aug 16 2022, 12:26 PM
Dzahn added a comment.Aug 23 2022, 1:39 PM

Just ran across this while looking through Phabricator history. It seems all subtasks are resolved. What is left to do here?

Is decom'ing scandium part of this (at some point)? or not?

ssastry added a comment.Aug 23 2022, 1:51 PM

No! :) scandium is now Parsoid/PHP. AFAICT, I think this task can be resolved. But, you all should evaluate in case there are any lingering Parsoid/JS things lying around in puppet.

gerritbot added a comment.Aug 23 2022, 1:59 PM

Change 825753 had a related patch set uploaded (by Dzahn; author: Dzahn):

[operations/puppet@production] scap/dsh: remove parsoid service, replaced by parsoid-php

https://gerrit.wikimedia.org/r/825753

gerritbot added a project: Patch-For-Review.Aug 23 2022, 1:59 PM
Dzahn added a comment.Aug 23 2022, 2:01 PM

@ssastry Alright, thanks. I found a small remnant.

jijiki moved this task from Incoming 🐫 to 🙈🙉🙊Backlog on the serviceops board.Sep 28 2022, 2:27 PM
gerritbot added a comment.Oct 21 2022, 3:57 PM

Change 825753 abandoned by Dzahn:

[operations/puppet@production] scap/dsh: remove parsoid service, replaced by parsoid-php

Reason:

referenced in scap configuration

https://gerrit.wikimedia.org/r/825753

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2022, 4:30 PM
jijiki subscribed.Nov 8 2022, 3:49 PM

@Dzahn If there is anything left here, I reckon we can mark it as resolved? Thank you!

Dzahn closed this task as Resolved.Nov 8 2022, 5:55 PM
Dzahn claimed this task.

@jijiki There is a small detail left but I am not going to work on it. It requires changes to scap config first.

I don't mind if it gets closed though. No strong opinion here. It depends on the definition of what belongs to "decom from the cluster".

Well.. thinking about it.. it is effectively decom'ed from the cluster, what I am talking about is remnants in repos. so... let's close it.

If anyone disagrees please just reopen.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits