Page MenuHomePhabricator
Create Task
Maniphest T242843

Display UNSUPPORTED_ENTITY_DATA error in ErrorWrapper
Closed, ResolvedPublic
Actions

Description

Details

SubjectRepoBranchLines +/-
bridge: add browser tests for data type bail-outmediawiki/extensions/Wikibasemaster+555 -297
bridge: wire up UnsupportedDatatypeError in ErrorWrappermediawiki/extensions/Wikibasemaster+544 -123
bridge: Create UnsupportedDatatype componentmediawiki/extensions/Wikibasemaster+191 -0
bridge: add more details to unsupported datatype errormediawiki/extensions/Wikibasemaster+49 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pablo-WMDE created this task.Jan 15 2020, 12:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2020, 12:12 PM
Lucas_Werkmeister_WMDE changed the task status from Open to Stalled.Jan 27 2020, 2:34 PM
Lucas_Werkmeister_WMDE added subscribers: Lydia_Pintscher, Lucas_Werkmeister_WMDE.

add messages for bailout reason "datatype"

I don’t think we have that bailout reason at the moment. We show an error when the data value type isn’t string (e. g. wikibase-entityid, quantity), but we never check the data type (e. g. URLs, Commons media values, and others are currently supported).

@Lydia_Pintscher should we switch this task to bail out on invalid data value type, or first add the currently missing check for the data type?

Lucas_Werkmeister_WMDE changed the task status from Stalled to Open.Jan 27 2020, 3:31 PM
Lucas_Werkmeister_WMDE added a subtask: T243773: Step 1: restrict editing to string data type - not just value type.
• Pablo-WMDE added a project: Wikidata-Bridge-Sprint-13.Jan 28 2020, 12:17 PM
• Tonina_Zhelyazkova_WMDE claimed this task.Jan 29 2020, 9:45 AM
• Tonina_Zhelyazkova_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-13 board.
gerritbot added a comment.Jan 30 2020, 4:06 PM

Change 569020 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Create UnsupportedDatatype component

https://gerrit.wikimedia.org/r/569020

gerritbot added a project: Patch-For-Review.Jan 30 2020, 4:06 PM
gerritbot added a comment.Feb 3 2020, 1:44 PM

Change 569543 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add more details to unsupported datatype error

https://gerrit.wikimedia.org/r/569543

gerritbot added a comment.Feb 3 2020, 2:35 PM

Change 569543 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add more details to unsupported datatype error

https://gerrit.wikimedia.org/r/569543

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 3 2020, 3:01 PM
gerritbot added a comment.Feb 3 2020, 3:26 PM

Change 569566 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: wire up UnsupportedDatatypeError in ErrorWrapper

https://gerrit.wikimedia.org/r/569566

Charlie_WMDE closed subtask T243773: Step 1: restrict editing to string data type - not just value type as Resolved.Feb 3 2020, 3:41 PM
gerritbot added a comment.Feb 3 2020, 5:33 PM

Change 569020 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Create UnsupportedDatatype component

https://gerrit.wikimedia.org/r/569020

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-13 board.Feb 3 2020, 5:34 PM
gerritbot added a comment.Feb 3 2020, 6:17 PM

Change 569587 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add browser tests for data type bail-out

https://gerrit.wikimedia.org/r/569587

gerritbot added a comment.Feb 4 2020, 12:39 PM

Change 569566 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: wire up UnsupportedDatatypeError in ErrorWrapper

https://gerrit.wikimedia.org/r/569566

gerritbot added a comment.Feb 4 2020, 4:41 PM

Change 569587 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add browser tests for data type bail-out

https://gerrit.wikimedia.org/r/569587

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 4 2020, 4:44 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-13 board.
Maintenance_bot removed a project: Patch-For-Review.Feb 4 2020, 5:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits