Page MenuHomePhabricator
Create Task
Maniphest T242994

CentralAuth needs uses of global $wgUser removed
Open, Stalled, MediumPublic
Actions

Description

See parent task

Codesearch: https://codesearch.wmcloud.org/deployed/?q=wgUser(%5B%3B%2C%27%22-%5D%7C%5Cs%7C%24)&i=nope&files=%5C.php%24&repos=mediawiki/extensions/CentralAuth

Details

SubjectRepoBranchLines +/-
Remove a mention of $wgUser in a commentmediawiki/extensions/CentralAuthmaster+1 -1
Reduce direct references to $wgUsermediawiki/extensions/CentralAuthmaster+5 -4
Remove use of global $wgUser (part 2)mediawiki/extensions/CentralAuthmaster+12 -11
Remove use of global $wgUser (part 1)mediawiki/extensions/CentralAuthmaster+5 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.Jan 16 2020, 4:42 PM
DannyS712 created this task.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 16 2020, 4:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jan 16 2020, 4:42 PM

Change 565334 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralAuth@master] Remove use of global $wgUser (part 1)

https://gerrit.wikimedia.org/r/565334

gerritbot added a project: Patch-For-Review.Jan 16 2020, 4:43 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Jan 16 2020, 4:45 PM
gerritbot added a comment.Jan 19 2020, 12:10 AM

Change 565334 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Remove use of global $wgUser (part 1)

https://gerrit.wikimedia.org/r/565334

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 19 2020, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 19 2020, 1:10 AM
gerritbot added a comment.Jan 22 2020, 1:03 AM

Change 566392 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralAuth@master] Remove use of global $wgUser (part 2)

https://gerrit.wikimedia.org/r/566392

gerritbot added a project: Patch-For-Review.Jan 22 2020, 1:03 AM
DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Jan 28 2020, 8:50 PM
gerritbot added a comment.Jan 31 2020, 11:14 AM

Change 566392 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Remove use of global $wgUser (part 2)

https://gerrit.wikimedia.org/r/566392

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.18; 2020-02-04); removed MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 31 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 31 2020, 12:10 PM
TheSandDoctor subscribed.EditedJan 31 2020, 4:51 PM

@DannyS712 is there anything further needing doing here (specifically this subtask) or is this good to close?

DannyS712 added a comment.Jan 31 2020, 5:17 PM
In T242994#5842038, @TheSandDoctor wrote:

@DannyS712 is there anything further needing doing here (specifically this subtask) or is this good to close?

There is still more to do

DannyS712 added a parent task: T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].Feb 23 2020, 10:29 PM
DannyS712 removed a parent task: T159299: Deprecate and remove $wgUser.
DannyS712 changed the task status from Open to Stalled.Jun 6 2020, 4:54 AM
DannyS712 moved this task from In progress to Later on the User-DannyS712 board.

Remaining uses:
SpecialCentralLogin::doLoginComplete - writes to $wgUser, cannot be removed until after reading is deprecated with 1.35 release
DeleteEmptyAccounts::execute - writes to $wgUser, likewise cannot be removed

Stalling until 1.35 is cut

gerritbot added a comment.Jun 10 2020, 2:53 AM

Change 604229 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralAuth@master] Reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/604229

gerritbot added a project: Patch-For-Review.Jun 10 2020, 2:53 AM
gerritbot added a comment.Jun 10 2020, 4:59 AM

Change 604229 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/604229

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jun 10 2020, 5:00 AM
DannyS712 removed a project: Patch-For-Review.Jun 10 2020, 5:00 AM
DannyS712 updated the task description. (Show Details)Sep 13 2020, 8:09 PM
gerritbot added a comment.Sep 27 2020, 1:04 AM

Change 630239 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralAuth@master] Remove a mention of $wgUser in a comment

https://gerrit.wikimedia.org/r/630239

gerritbot added a project: Patch-For-Review.Sep 27 2020, 1:04 AM
gerritbot added a comment.Sep 27 2020, 3:00 PM

Change 630239 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Remove a mention of $wgUser in a comment

https://gerrit.wikimedia.org/r/630239

DannyS712 removed a project: Patch-For-Review.Sep 27 2020, 3:49 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 27 2020, 4:00 PM
DannyS712 added a subtask: T291515: PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute].Sep 22 2021, 3:48 PM
DannyS712 closed subtask T291515: PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute] as Resolved.Sep 23 2021, 10:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits