Page MenuHomePhabricator

Newcomer task: Article card - adjust the info icon size and position on mobile
Closed, ResolvedPublic

Description

Presently the info button on mobile is larger than expected, which is also causing it to not appear vertically centered with the task type label.

Expected: icon is 20x20px
image.png (256×590 px, 22 KB)
Actual: icon width is 22.84px
image.png (420×722 px, 44 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Etonkovidova -- could you please add what you think should be changed?

@Etonkovidova -- could you please add what you think should be changed?

It seems that the placement of info icon at the end of the label has been done already along with the patch -

https://gerrit.wikimedia.org/r/565717 - that fixed the placement of difficulty label on one line. So, this phab ticket can be closed, I suppose.

Screen Shot 2020-01-23 at 5.33.09 PM.png (554×429 px, 63 KB)

@Etonkovidova -- could you please add what you think should be changed?

It seems that the placement of info icon at the end of the label has been done already along with the patch -

https://gerrit.wikimedia.org/r/565717 - that fixed the placement of difficulty label on one line. So, this phab ticket can be closed, I suppose.

Screen Shot 2020-01-23 at 5.33.09 PM.png (554×429 px, 63 KB)

Yes, think this appears fixed now in terms of the icon position at the end of the type label, but there is still visual design items polish in the alignment of the icon and labels, so I'd like to keep this task open for those fixes. See the updated description.

RHo renamed this task from Newcomer task: Article card - adjust the info icon position to Newcomer task: Article card - adjust the info icon size and position on mobile.Jan 24 2020, 11:53 AM
RHo updated the task description. (Show Details)
RHo claimed this task.

This is no longer an issue

image.png (398×566 px, 42 KB)