HtmlPageLinkRendererBeginHookHandler creates a LanguageFallbackChain when it may not be needed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Addshore
	Jan 26 2020, 9:14 PM

Description

HtmlPageLinkRendererBeginHookHandler constructs a LanguageFallbackChain for injecting into a LanguageFallbackLabelDescriptionLookup.
But this may happen even when the language fallback chain is not actually needed, ie, getLabel or getDescription will never be called.

Instead the fallback chain should be injected or the creation of the fallback chain deferred.
Such as in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/567362/

Other code should also be checked for this bad pattern and fixed if it also occurs in other places.

Details

Subject	Repo	Branch	Lines +/-
Make HtmlPageLinkRendererBeginHookHandler do not build LFC unless needed	mediawiki/extensions/Wikibase	master	+53 -45
Don't make a fallback chain if it might not be needed	mediawiki/extensions/Wikibase	wmf/1.35.0-wmf.15	+26 -7
Don't make a fallback chain if it might not be needed	mediawiki/extensions/Wikibase	wmf/1.35.0-wmf.16	+26 -7
Don't make a fallback chain if it might not be needed	mediawiki/extensions/Wikibase	master	+26 -7

Customize query in gerrit

Related Objects

Mentioned In: T243915: Performance audit of Wikibase/Wikidata, Jan 2020
T243713: Time-out error; Babel/WikibaseRepo being somehow uncached, overloading the API, and causing general outage
T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove
T243726: Babel should get cross-wiki languages via DB instead of making an HTTP request
Mentioned Here: T243713: Time-out error; Babel/WikibaseRepo being somehow uncached, overloading the API, and causing general outage
T243726: Babel should get cross-wiki languages via DB instead of making an HTTP request
P10270 (An Untitled Masterwork)

Event Timeline

Addshore created this task.Jan 26 2020, 9:14 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 26 2020, 9:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 26 2020, 9:15 PM

Addshore triaged this task as High priority.Jan 26 2020, 9:15 PM

Addshore added a project: User-Addshore.Jan 26 2020, 9:24 PM

Addshore awarded a token.

Change 567362 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Don't make a fallback chain if it might not be needed

https://gerrit.wikimedia.org/r/567362

Change 567363 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.16] Don't make a fallback chain if it might not be needed

https://gerrit.wikimedia.org/r/567363

Change 567364 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.15] Don't make a fallback chain if it might not be needed

https://gerrit.wikimedia.org/r/567364

Addshore claimed this task.Jan 26 2020, 9:31 PM

Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.

Addshore added projects: Structured Data Engineering, StructuredDataOnCommons.Jan 26 2020, 9:34 PM

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptJan 26 2020, 9:34 PM

Addshore added subscribers: WMDE-leszek, darthmon_wmde, Jakob_WMDE and 4 others.Jan 26 2020, 9:34 PM

Bawolff mentioned this in T243726: Babel should get cross-wiki languages via DB instead of making an HTTP request.Jan 26 2020, 9:34 PM

Addshore updated the task description. (Show Details)Jan 26 2020, 9:36 PM

Addshore mentioned this in T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove.Jan 26 2020, 9:50 PM

Jdforrester-WMF subscribed.Jan 26 2020, 9:57 PM

Addshore updated the task description. (Show Details)Jan 26 2020, 10:30 PM

Change 567362 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don't make a fallback chain if it might not be needed

https://gerrit.wikimedia.org/r/567362

Change 567363 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.16] Don't make a fallback chain if it might not be needed

https://gerrit.wikimedia.org/r/567363

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 26 2020, 11:00 PM

I also think we should stop using that hook, it's just too general for our use.

Michael subscribed.Jan 27 2020, 9:59 AM

Addshore removed Addshore as the assignee of this task.Jan 27 2020, 10:25 AM

Ladsgroup claimed this task.Jan 27 2020, 10:29 AM

Ladsgroup moved this task from To Do to Doing on the Structured Data Engineering board.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 27 2020, 10:29 AM

Relates to T243713: Time-out error; Babel/WikibaseRepo being somehow uncached, overloading the API, and causing general outage

Michael mentioned this in T243713: Time-out error; Babel/WikibaseRepo being somehow uncached, overloading the API, and causing general outage.Jan 27 2020, 10:58 AM

Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Jan 27 2020, 11:15 AM

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 27 2020, 11:24 AM

Change 567364 abandoned by Addshore:
Don't make a fallback chain if it might not be needed

Reason:
Abandoning as we probably wont backport this.
Feel free to revive if needed

https://gerrit.wikimedia.org/r/567364

Maintenance_bot removed a project: Patch-For-Review.Jan 27 2020, 2:10 PM

Change 567467 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Make HtmlPageLinkRendererBeginHookHandler do not build LFC unless needed

https://gerrit.wikimedia.org/r/567467

gerritbot added a project: Patch-For-Review.Jan 27 2020, 3:28 PM

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 27 2020, 5:01 PM

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 29 2020, 2:52 PM

Change 567467 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make HtmlPageLinkRendererBeginHookHandler do not build LFC unless needed

https://gerrit.wikimedia.org/r/567467

Maintenance_bot removed a project: Patch-For-Review.Jan 29 2020, 4:10 PM

Ladsgroup mentioned this in T243915: Performance audit of Wikibase/Wikidata, Jan 2020.Jan 29 2020, 4:16 PM

Impact to number of calls to the memcached key when deployed in production today.

Addshore closed this task as Resolved.Feb 4 2020, 5:06 PM

Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.Feb 4 2020, 5:15 PM

	F31547589: image.png
	Feb 4 2020, 4:59 PM

HtmlPageLinkRendererBeginHookHandler creates a LanguageFallbackChain when it may not be neededClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

HtmlPageLinkRendererBeginHookHandler creates a LanguageFallbackChain when it may not be needed
Closed, ResolvedPublic
Actions