Page MenuHomePhabricator
Create Task
Maniphest T245692

[Investigate] Why does parser detect a comment when a link to a person's user page, talk page or contributions page is missing.
Closed, ResolvedPublic
Actions

Description

Actual behavior

  1. Visit: https://nl.wikipedia.org/wiki/Overleg_gebruiker:213.124.17.165?dtenable=1 or https://nl.wikipedia.org/wiki/Overleg_gebruiker:78.21.12.96?dtenable=1
  2. Observe a list of vandalistic edits this person has made within the section titled "Dossier 2018-2019"

⚠️ 3. Observe reply links ("Antwoorden") are being appended to each of these vandalistic edit list items despite them not containing a link to a person's user page, talk page or contributions page.

Expected behavior

  1. Visit: https://nl.wikipedia.org/wiki/Overleg_gebruiker:213.124.17.165?dtenable=1 or https://nl.wikipedia.org/wiki/Overleg_gebruiker:78.21.12.96?dtenable=1
  2. Observe a list of vandalistic edits this person has made within the section titled "Dossier 2018-2019"

✅ 3. Observe reply links ("Antwoorden") are not being appended to each of these vandalistic edit list items

Done

  • Document why the "Actual behavior" is happening: is this a bug in the comment parser? Is this a use case we have not yet designed for? See: T245692#5899556
  • Document what would be involved in fixing this behavior. Documenting the approach not needed. Why? Issue is fixed. See: T245692#5912210

Additional context: T244432#5895971

Details

SubjectRepoBranchLines +/-
Only detect comments with real signaturesmediawiki/extensions/DiscussionToolsmaster+122 -499
Customize query in gerrit

Related Objects
Search...

Event Timeline

ppelberg created this task.Feb 19 2020, 11:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 19 2020, 11:53 PM
ppelberg updated the task description. (Show Details)Feb 19 2020, 11:54 PM
ppelberg moved this task from Needs Discussion / Investigation to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.
ppelberg moved this task from Needs Prioritization to Required before Release on the OWC2020 (OWC2020 Replying 1.0) board.
ppelberg mentioned this in T244432: Evaluate reliability of #DiscussionTools on target wikis.
ppelberg added a parent task: T244432: Evaluate reliability of #DiscussionTools on target wikis.
ppelberg updated the task description. (Show Details)Feb 19 2020, 11:57 PM
matmarex added a comment.Feb 20 2020, 12:10 AM

This happens because we try to recognize comments with a timestamp but without a signature. This was meant to allow replying to announcements posted by some bots, e.g. https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_179#Tech_News:_2020-06 (note how the initial comment ends with "20:04, 3 February 2020 (UTC)" and no signature). But it seems like it will cause issues more often than it helps, so we should probably only detect comments with real signatures.

matmarex added a project: DiscussionTools.Feb 20 2020, 12:15 AM
ppelberg added a comment.Feb 20 2020, 12:24 AM
In T245692#5899556, @matmarex wrote:

This happens because we try to recognize comments with a timestamp but without a signature. This was meant to allow replying to announcements posted by some bots, e.g. https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_179#Tech_News:_2020-06 (note how the initial comment ends with "20:04, 3 February 2020 (UTC)" and no signature). But it seems like it will cause issues more often than it helps, so we should probably only detect comments with real signatures.

+1 to adapting the parser to, "...only detect comments with real signatures."

ppelberg updated the task description. (Show Details)Feb 20 2020, 12:30 AM
matmarex triaged this task as High priority.Feb 20 2020, 6:20 PM
matmarex claimed this task.Feb 20 2020, 11:19 PM
gerritbot added a comment.Feb 20 2020, 11:48 PM

Change 573773 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Only detect comments with real signatures

https://gerrit.wikimedia.org/r/573773

gerritbot added a project: Patch-For-Review.Feb 20 2020, 11:48 PM
matmarex moved this task from Ready for Development to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 21 2020, 12:34 AM
gerritbot added a comment.Feb 24 2020, 3:08 PM

Change 573773 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Only detect comments with real signatures

https://gerrit.wikimedia.org/r/573773

Maintenance_bot removed a project: Patch-For-Review.Feb 24 2020, 3:11 PM
• Esanders moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 24 2020, 3:33 PM
JTannerWMF added a project: Editing QA.Feb 25 2020, 10:41 PM
JTannerWMF moved this task from Inbox to High Priority on the Editing QA board.
matmarex mentioned this in T242372: Can we suppress Reply links if the signature is from a bot?.Mar 2 2020, 11:40 PM
AdHuikeshoven awarded a token.Mar 3 2020, 2:38 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Mar 4 2020, 9:55 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
ppelberg closed this task as Resolved.Mar 5 2020, 7:29 PM
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits