notes from story writing:

• existing patterns:
  • wikitext editor: warning banner over text input field
  • VisualEditor: popup coming out of the toolbar in the top right corner
  • Wikibase default: bubble in top right corner - mw.notify
  • Termbox: banner coming in from the top
  • Structured Data on Commons: same as Wikibase default
• technically it is probably possible to do something similar in the same place as Wikibase does it but probably not the right thing for Bridge

I assume the warning should take precedence over the loading screen, but the loading should still happen in the background. What happens, then, if there is an error (e. g. page protected on repo) while loading, before the user has dismissed the warning? What’s more important, the warning or the error? Do we leave the warning on the screen until the user has dismissed it, or replace it with an error as soon as the error happens?

hey @Lucas_Werkmeister_WMDE those are all very good questions.

warning should take precedence over the loading screen = yes
loading still happens in the background = yes
what's more important, the warning or the error = the error

which brings me to the last question

what happens when there's an error? ideally the error would be shown before anything else. that should be possible for repo protection etc, no? for server problems maybe not? but in that case it's fine to show the warning, then i guess the loading in the background would have failed anyway, and then we'd see the server error. once the warning screen (or any screen except for the loading screen) is shown in general, we should leave it until the moment the user interacts with it. so if they see an error, then until they fix it or dismiss it, the warning isn't shown. same goes the other way round. if we show the warning, we don't "interrupt" the screen by showing the error when it's ready.

hope this is helpful

ideally the error would be shown before anything else. that should be possible for repo protection etc, no?

No, unfortunately. We only know if the page is protected on the repo after making an API request, which takes a while. On the other hand, we know if this warning should be shown or not as soon as the bridge is opened, without further delay. There might be some error that can also happen immediately (I can’t think of one at the moment), but in general, the warning is going to happen before an error, unless we delay the warning (but you already said the warning should take precedence over the loading screen).

okay, that is indeed unfortunate. I would still keep this order then

1. warning
2. error
3. bridge

loading screen where necessary but none of the screens above should be "interrupted" by any other screen (including the loading screen)

Okay, then I think that’s what my current changes already do. Thanks!

when using vektor (not minerva) there seem to be additional margins that shouldn't be there. after discussing with @Michael it might be due to the icon height placement.

Change 595902 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Remove erroneous margin from anon warning message

https://gerrit.wikimedia.org/r/595902

Change 595902 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Remove erroneous margin from anon warning message

https://gerrit.wikimedia.org/r/595902