Page MenuHomePhabricator

Convert TrackingCategories to a service with DI
Closed, ResolvedPublic

Description

the TrackingCategories class uses

  • $wgTrackingCategories (via Config)
  • $wgEnableMagicLinks (via Config)
  • the NamespaceInfo service
  • Multiple title calls that could be done via a TitleFactory

I suggest that it be converted to a service with these injected (currently created with a Config object, but still retrieves nsinfo and uses Title:: repeatedly)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Pchelolo added a subscriber: Pchelolo.

I guess you need an approval of this plan from the CPT. Moving into triage meeting inbox to discuss.

I guess you need an approval of this plan from the CPT. Moving into triage meeting inbox to discuss.

{{ping}} Any updates?

daniel added a subscriber: daniel.

looks good at a glance

DannyS712 moved this task from Next to Later on the User-DannyS712 board.

Unlicking, probably won't get to this soon

Change 634090 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Convert TrackingCategories to a service with DI

https://gerrit.wikimedia.org/r/634090

Change 728563 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Make TrackingCategories into a service

https://gerrit.wikimedia.org/r/728563

Change 728563 abandoned by C. Scott Ananian:

[mediawiki/core@master] Make TrackingCategories into a service

Reason:

abandoned in favor of I50012e2a5e65aeee7671023d2fd5367e21e8ae67

https://gerrit.wikimedia.org/r/728563

Change 634090 merged by jenkins-bot:

[mediawiki/core@master] Convert TrackingCategories to a service with DI

https://gerrit.wikimedia.org/r/634090

matej_suchanek reassigned this task from DannyS712 to cscott.