Introduce UserMailer as a service
Closed, ResolvedPublic
Actions

Description

Motivation

At the moment the sending emails are possible using a static UserMailer::send function.
It makes impossible to write tests for code which is going to send emails.

Expected result

SendMail class/interface should be introduced and registered in MediaWikiSerrvices.

Details

	Subject	Repo	Branch	Lines +/-
	Introduce Emailer as service	mediawiki/core	master	+138 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T247977 Implement Hash Checking of Media Files
Resolved	Peter.ovchyn	T245595 MediaModeration extension MVP
Resolved	Peter.ovchyn	T246255 MediaModeration: Strategy for handling child protection media
Resolved	Peter.ovchyn	T247229 Introduce UserMailer as a service

Event Timeline

Peter.ovchyn created this task.Mar 9 2020, 10:06 AM

Change 578309 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] Introduce EmailSender as service

https://gerrit.wikimedia.org/r/578309

gerritbot added a project: Patch-For-Review.Mar 9 2020, 11:01 AM

Peter.ovchyn moved this task from Backlog to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Mar 9 2020, 12:16 PM

• Pchelolo edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards (S&F Workboard).Mar 11 2020, 12:44 AM

• Pchelolo moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.

DannyS712 subscribed.Mar 11 2020, 8:33 AM

Peter.ovchyn mentioned this in T247393: Replace static calls related to UserMail with calling respective methods of EmailSender service.Mar 11 2020, 9:02 AM

Peter.ovchyn edited projects, added Platform Team Workboards (S&F Workboard); removed Platform Team Workboards (Clinic Duty Team).

Peter.ovchyn edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards (S&F Workboard).

@Pchelolo Damn, it's impossible to keep it on both boards/projects. Don't you mind if I add it back to Contractor Workboard as at the moment it's my primary operational board? Once I completely switch to Clinic Duty I'll use its board.