The 'Publishers' field in NewsletterEditPage has required=false and exists=true. Before T246958, that means that it will not successfully submit if empty.
After T246958, this field will successfully submit if empty. NewsletterEditPage::getManageForm should return a confirmation warning if 'Publishers' is empty, but handles the empty input incorrectly, and an error is thrown from getIdsFromUsers.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| NewsletterEditPage: Fix handling of empty 'Publishers' field | mediawiki/extensions/Newsletter | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | dbarratt | T247279 Filters on Special:Investigate should validate users | |||
| Resolved | dbarratt | T246958 HTMLUsersMultiselectField fails validation when exists is true, but required is false | |||
| Resolved | Tchanders | T247760 Fix handling of empty 'Publishers' field in NewsletterEditPage |
Change 580063 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/Newsletter@master] NewsletterEditPage: Fix handling of empty 'Publishers' field
Change 580063 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] NewsletterEditPage: Fix handling of empty 'Publishers' field
Testing on https://en.wikipedia.beta.wmflabs.org.
Special:Newsletter?action=edit:
| Input | JS | No JS |
| Empty | Shows confirmation*; saves without publishers | Shows confirmation*; saves without publishers |
| Non-existent user | Shows confirmation*; saves without publishers | "$user does not exist" |
| Existent user | Saves existent user as publisher | Saves existent user as publisher |
| Existent + non-existent | Only saves existent user as publishers | "$user does not exist" |
* "Are you sure that you want to remove all the publishers from this newsletter?"
For invalid input (e.g. "user|name") it behaves like non-existent user input on JS and non-JS.