Template partial/Stylesheet files that are not components are confusing to quickly get overview
Questions I'd like to find answers for:
[✔️] Should we keep all the legacy stylesheets and templates in a respective 'legacy' folder?
[✔️] Let's break up common.css into manageable chunks. Please input on how that should be done. https://gerrit.wikimedia.org/r/587855
[✔️] After https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/578660/ is merged the master templates are called index.mustache (new) and legacy.mustache (old). Are these names acceptable and meaningful given the split? Should we rename to e.g. 'skin' / 'page' / 'layout' / 'pagelayout' / 'master' / 'root' / 'modern' / 'vector'?
The following tasks were originally part of this spike, but given the fact they are not blocking us now and are lower priority they have been broken out into
- T253669: [SPIKE] Discuss template partials in Vector
- T253671: [SPIKE] What's going on with BEM in Vector?
- T257145: Discuss renaming Vector's 'variables.less'
Results summary of the "collaboration" on the agreed nomenclature
These tasks have reached their final state in May, activity ceased. The subtasks, including related changes:
Completion - Proposer - Subtask format
- Jdlrobson - keep legacy stylesheets and templates in a respective 'legacy' folder
- Jdlrobson - break up 'common.css' into manageable chunks (patch 587855): content.less, print.less, typography.less
- Volker - extract 'normalize.less' (patch 604939)
- Volker - T257145 rename 'variables.less' to 'vector.variables.less' (patch 603660)
- Demian - T253669 split 'content.mustache' from 'skin.mustache' and 'legacy/content.mustache' from 'skin-legacy.mustache' (patch 585625)
- Demian - add .mw-tabs (or similar) class to #mw-head
- Demian - (not important) split #mw-head from 'index.mustache' and 'legacy.mustache' into the reusable 'Tabs.mustache' (patch 585626)
- Jdlrobson - add .vector-menu-tabs class to #left-navigation and #right-navigation (T249372, patch 595001)
- Jdlrobson - epic menu templating code refactor (T249372)
- Volker - rename 'index.mustache' (only the template) to 'skin.mustache' (patch 596512)
- Jdlrobson - rename 'watchstar-ie8.less' to 'TabWatchstarLink.less' (patch 587855)