Page MenuHomePhabricator

add error variant to IconMessageBox
Closed, ResolvedPublic

Description

  • icon from ooui
  • style border and background color according to mock-up
  • verify spacings are correct - talk to UX to make sure that these are consistent between the notice and error variant

Event Timeline

Change 585278 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add error type to IconMessageBox

https://gerrit.wikimedia.org/r/585278

Change 585279 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: fix spacing of IconMessageBox

https://gerrit.wikimedia.org/r/585279

Note for reviewers: some message boxes in Figma look like they have 13px/25px spacing, but that’s only because the 1px border is included.

@Charlie_WMDE Figma specifies 1.6 line-height, but currently the IconMessageBox has 1.5 line-height (story). Should we fix that here, or leave it for later with the rest of T246117: Visual fixes?

(Technically, it currently shares the same styles as other “body S” components, so fixing the line-height only for IconMessageBox would be a bit annoying to implement.)

Change 585278 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add error type to IconMessageBox

https://gerrit.wikimedia.org/r/585278

Change 585279 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: fix spacing of IconMessageBox

https://gerrit.wikimedia.org/r/585279

Moving to Verification (instead of Done) because I’m still not sure about the line-height. (See storybook for how it looks now.)

@Lucas_Werkmeister_WMDE should i be verifying this? if yes, what am i verifying?

Yes, mainly this – current line-height is 1.5, Figma says 1.6, unclear if that should be changed in this task or the already existing follow-up:

@Charlie_WMDE Figma specifies 1.6 line-height, but currently the IconMessageBox has 1.5 line-height (story). Should we fix that here, or leave it for later with the rest of T246117: Visual fixes?

(Technically, it currently shares the same styles as other “body S” components, so fixing the line-height only for IconMessageBox would be a bit annoying to implement.)

@Lucas_Werkmeister_WMDE if it would get updated "automatically" with a change to body S then i say, leave it as is ie can be moved to done imo