Page MenuHomePhabricator
Create Task
Maniphest T249121

add error variant to IconMessageBox
Closed, ResolvedPublic
Actions

Description

  • icon from ooui
  • style border and background color according to mock-up
  • verify spacings are correct - talk to UX to make sure that these are consistent between the notice and error variant

Details

SubjectRepoBranchLines +/-
bridge: fix spacing of IconMessageBoxmediawiki/extensions/Wikibasemaster+6 -4
bridge: add error type to IconMessageBoxmediawiki/extensions/Wikibasemaster+54 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pablo-WMDE created this task.Apr 1 2020, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 3:08 PM
• Pablo-WMDE mentioned this in T249123: Mend ErrorUnknown to show information per mock-up.Apr 1 2020, 3:09 PM
• Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-17; removed Wikidata-Bridge.Apr 1 2020, 3:41 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 1 2020, 4:02 PM
Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-17 board.
gerritbot added a comment.Apr 1 2020, 5:11 PM

Change 585278 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add error type to IconMessageBox

https://gerrit.wikimedia.org/r/585278

gerritbot added a project: Patch-For-Review.Apr 1 2020, 5:11 PM

Change 585279 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: fix spacing of IconMessageBox

https://gerrit.wikimedia.org/r/585279

Lucas_Werkmeister_WMDE added a comment.Apr 1 2020, 5:13 PM

Note for reviewers: some message boxes in Figma look like they have 13px/25px spacing, but that’s only because the 1px border is included.

space.png (501×1 px, 48 KB)

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-17 board.Apr 1 2020, 5:14 PM
Lucas_Werkmeister_WMDE added a subscriber: Charlie_WMDE.EditedApr 1 2020, 5:17 PM

@Charlie_WMDE Figma specifies 1.6 line-height, but currently the IconMessageBox has 1.5 line-height (story). Should we fix that here, or leave it for later with the rest of T246117: Visual fixes?

(Technically, it currently shares the same styles as other “body S” components, so fixing the line-height only for IconMessageBox would be a bit annoying to implement.)

gerritbot added a comment.Apr 3 2020, 4:37 PM

Change 585278 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add error type to IconMessageBox

https://gerrit.wikimedia.org/r/585278

gerritbot added a comment.Apr 3 2020, 4:39 PM

Change 585279 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: fix spacing of IconMessageBox

https://gerrit.wikimedia.org/r/585279

Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-17 board.EditedApr 3 2020, 4:57 PM

Moving to Verification (instead of Done) because I’m still not sure about the line-height. (See storybook for how it looks now.)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 3 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 3 2020, 5:10 PM
Charlie_WMDE added a comment.Apr 6 2020, 11:08 AM

@Lucas_Werkmeister_WMDE should i be verifying this? if yes, what am i verifying?

Lucas_Werkmeister_WMDE added a comment.Apr 6 2020, 11:23 AM

Yes, mainly this – current line-height is 1.5, Figma says 1.6, unclear if that should be changed in this task or the already existing follow-up:

In T249121#6019944, @Lucas_Werkmeister_WMDE wrote:

@Charlie_WMDE Figma specifies 1.6 line-height, but currently the IconMessageBox has 1.5 line-height (story). Should we fix that here, or leave it for later with the rest of T246117: Visual fixes?

(Technically, it currently shares the same styles as other “body S” components, so fixing the line-height only for IconMessageBox would be a bit annoying to implement.)

Charlie_WMDE added a comment.Apr 6 2020, 3:42 PM

@Lucas_Werkmeister_WMDE if it would get updated "automatically" with a change to body S then i say, leave it as is ie can be moved to done imo

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 6 2020, 3:45 PM
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-17 board.

It should, yes. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits