Page MenuHomePhabricator
Create Task
Maniphest T249181

Remove usages and drop hard deprecated User methods
Closed, ResolvedPublic
Actions

Description

Calls that must be resolved:

  • User::setPassword() - Installer (r585472); resetUserEmail.php (r585477); removal (r609485)
  • User::setInternalPassword() - (r607766)
  • User::checkPassword() - (r596716)
  • User::checkTemporaryPassword() -
  • User::setPasswordInternal() - (r609485)
  • User::selectFields - user/UserTest.php (r585334)

Other calls:

Details

SubjectRepoBranchLines +/-
Remove selectFields User methodmediawiki/coremaster+5 -26
Remove User::setPassword()mediawiki/coremaster+2 -57
Remove User::setInternalPassword()mediawiki/coremaster+2 -13
Drop User::checkPassword()mediawiki/coremaster+2 -36
Installer: Remove call to deprecated setPassword() User methodmediawiki/coremaster+9 -4
Remove call to deprecated setPassword() User methodmediawiki/coremaster+11 -2
Drop back-compat code to remove call to deprecated setPassword() methodmediawiki/extensions/AutoProxyBlockmaster+1 -16
Drop User::checkTemporaryPassword()mediawiki/coremaster+2 -14
Add method to check user passwordmediawiki/extensions/OpenIDmaster+27 -3
Avoid use of deprecated User::selectFields methodmediawiki/extensions/AzharAuthmaster+6 -4
Customize query in gerrit

Related Objects

Event Timeline

Ammarpad created this task.Apr 1 2020, 11:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 11:39 PM
gerritbot added a comment.Apr 1 2020, 11:42 PM

Change 585350 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/OpenID@master] Add method to check user passwords

https://gerrit.wikimedia.org/r/585350

gerritbot added a project: Patch-For-Review.Apr 1 2020, 11:42 PM
Ammarpad added projects: MediaWiki-extensions-OpenID, Technical-Debt (Deprecation process).Apr 1 2020, 11:43 PM
Ammarpad mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.Apr 2 2020, 12:37 AM
Ammarpad added a project: MediaWiki-Installer.Apr 2 2020, 10:57 AM
gerritbot added a comment.Apr 2 2020, 11:02 AM

Change 585472 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Installer: Remove call to deprecated setPassword() User method

https://gerrit.wikimedia.org/r/585472

gerritbot added a comment.Apr 2 2020, 11:31 AM

Change 585477 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove call to deprecated setPassword() User method

https://gerrit.wikimedia.org/r/585477

Ammarpad updated the task description. (Show Details)Apr 2 2020, 12:05 PM
gerritbot added a comment.Apr 2 2020, 12:52 PM

Change 585487 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/AutoProxyBlock@master] Drop back-compat code to help remove call to deprecated setPassword() method

https://gerrit.wikimedia.org/r/585487

Ammarpad added a project: MediaWiki-extensions-AutoProxyBlock.Apr 2 2020, 1:04 PM
Ammarpad updated the task description. (Show Details)
gerritbot added a comment.Apr 2 2020, 1:05 PM

Change 585332 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/AzharAuth@master] Avoid use of deprecated User::selectFields method

https://gerrit.wikimedia.org/r/585332

gerritbot added a comment.Apr 2 2020, 1:06 PM

Change 585334 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove usage of deprecated selectFields method from UserTest

https://gerrit.wikimedia.org/r/585334

Ammarpad added a project: Platform Engineering.May 1 2020, 9:45 AM
daniel edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.May 1 2020, 11:59 AM
gerritbot added a comment.May 1 2020, 4:39 PM

Change 585332 merged by jenkins-bot:
[mediawiki/extensions/AzharAuth@master] Avoid use of deprecated User::selectFields method

https://gerrit.wikimedia.org/r/585332

Ammarpad updated the task description. (Show Details)May 5 2020, 5:25 AM
gerritbot added a comment.May 13 2020, 8:41 PM

Change 585350 merged by jenkins-bot:
[mediawiki/extensions/OpenID@master] Add method to check user password

https://gerrit.wikimedia.org/r/585350

CCicalese_WMF moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.May 13 2020, 8:48 PM
CCicalese_WMF moved this task from External Code Review Completed to External Code Review Needed on the Platform Team Workboards (External Code Reviews) board.
Ammarpad updated the task description. (Show Details)May 15 2020, 1:39 PM
gerritbot added a comment.May 15 2020, 5:37 PM

Change 596711 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Drop User::checkTemporaryPassword()

https://gerrit.wikimedia.org/r/596711

gerritbot added a comment.May 15 2020, 5:48 PM

Change 596716 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Drop User::checkPassword()

https://gerrit.wikimedia.org/r/596716

gerritbot added a comment.May 15 2020, 6:07 PM

Change 596711 merged by jenkins-bot:
[mediawiki/core@master] Drop User::checkTemporaryPassword()

https://gerrit.wikimedia.org/r/596711

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 15 2020, 7:00 PM
gerritbot added a comment.Jun 25 2020, 4:32 AM

Change 585487 merged by jenkins-bot:
[mediawiki/extensions/AutoProxyBlock@master] Drop back-compat code to remove call to deprecated setPassword() method

https://gerrit.wikimedia.org/r/585487

gerritbot added a comment.Jun 25 2020, 4:48 AM

Change 585477 merged by jenkins-bot:
[mediawiki/core@master] Remove call to deprecated setPassword() User method

https://gerrit.wikimedia.org/r/585477

gerritbot added a comment.Jun 25 2020, 4:52 AM

Change 585472 merged by jenkins-bot:
[mediawiki/core@master] Installer: Remove call to deprecated setPassword() User method

https://gerrit.wikimedia.org/r/585472

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.39; 2020-06-30); removed MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).Jun 25 2020, 5:00 AM
gerritbot added a comment.Jun 25 2020, 11:43 AM

Change 607766 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove User::setInternalPassword()

https://gerrit.wikimedia.org/r/607766

gerritbot added a comment.Jun 25 2020, 11:46 AM

Change 596716 merged by jenkins-bot:
[mediawiki/core@master] Drop User::checkPassword()

https://gerrit.wikimedia.org/r/596716

Ammarpad updated the task description. (Show Details)Jun 25 2020, 11:49 AM
gerritbot added a comment.Jun 25 2020, 1:47 PM

Change 607766 merged by jenkins-bot:
[mediawiki/core@master] Remove User::setInternalPassword()

https://gerrit.wikimedia.org/r/607766

Krinkle mentioned this in T256829: Travis CI builds failing on "The password entered is in a list of very commonly used passwords.".Jul 1 2020, 2:04 AM
Tgr mentioned this in T256620: MediaWiki CLI installer should check wiki admin password validity before starting.Jul 1 2020, 1:47 PM
gerritbot added a comment.Jul 3 2020, 7:08 PM

Change 609485 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove User::setPassword()

https://gerrit.wikimedia.org/r/609485

Ammarpad triaged this task as Medium priority.Jul 3 2020, 7:43 PM
Ammarpad updated the task description. (Show Details)
Ammarpad updated the task description. (Show Details)Jul 10 2020, 8:05 AM
Jdforrester-WMF updated the task description. (Show Details)Jul 12 2020, 1:58 PM
gerritbot added a comment.Jul 12 2020, 2:17 PM

Change 609485 merged by jenkins-bot:
[mediawiki/core@master] Remove User::setPassword()

https://gerrit.wikimedia.org/r/609485

gerritbot added a comment.Jul 12 2020, 2:47 PM

Change 585334 merged by jenkins-bot:
[mediawiki/core@master] Remove selectFields User method

https://gerrit.wikimedia.org/r/585334

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.41; 2020-07-14); removed MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jul 12 2020, 3:00 PM
Tgr awarded a token.Jul 12 2020, 4:59 PM
Ammarpad renamed this task from Drop hard deprecated User methods to Remove usages and drop hard deprecated User methods.Jul 12 2020, 6:40 PM
Ammarpad closed this task as Resolved.
Ammarpad removed a project: Patch-For-Review.
Ammarpad updated the task description. (Show Details)
Ammarpad claimed this task.Jul 13 2020, 4:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL